From: Emil Velikov <emil.l.velikov@gmail.com>
To: linux-firmware@kernel.org
Cc: emil.l.velikov@gmail.com
Subject: [PATCH 00/15] Misc fixes, sanity checks and xz/zstd compression
Date: Sat, 18 Feb 2023 18:46:06 +0000 [thread overview]
Message-ID: <20230218184621.2026504-1-emil.l.velikov@gmail.com> (raw)
Greetings everyone,
For a while now, the kernel has been accepting compressed firmware - be that xz
or zstd. There is a patch for the former on the ML, yet the latter is still
lacking.
While working through I've noticed a few issues - of various severity - so
decided to fix them all.
Mind you, I'm sending everything as single patch series to gauge feedback. I'm
quite happy to split and rework as per the community's feedback.
In a gist:
- remove quoted filenames in WHENCE - escape white space as needed
- remove _nearly_ all duplicate entries in WHENCE && add check
- NOTE: one entry remains, which I'm not sure how to resolve cleanly
- check if directory is listed as File - had a mistake like that locally
- check we have no symlinks and drop symlink workarounds
- quote deskdir (genuine bug) + few more shellcheck inspired fixes
- support xz and zstd compressed firmware - no intermediate files, pipe
directly into destdir
Kind regards
Emil
Emil Velikov (15):
WHENCE: remove trailing white space
WHENCE: remove unnecessary filename quotation
check_whence, WHENCE, copy-firmware: escape filenames with spaces
WHENCE: remove duplicate File entries
check_whence: error on duplicate file entries
check_whence: error on directory listed as File
copy-firmware: remove non-applicable file presence test
check_whence: error if File: is actually a link
check_whence: error if symlinks are in-tree
copy-firmware: remove unreachable symlink workarounds
copy-firmware: quote deskdir to prevent word splitting
copy-firmware: tweak sed invocation
copy-firmware: quote the output of dirname
copy-firmware: silence the last shellcheck warnings
Makefile, copy-firmware: support xz/zstd compressed firmware
Makefile | 8 ++++
WHENCE | 97 +++++++++++++++++++-----------------------------
check_whence.py | 44 +++++++++++++++++++---
copy-firmware.sh | 71 +++++++++++++++++------------------
4 files changed, 119 insertions(+), 101 deletions(-)
--
2.39.2
next reply other threads:[~2023-02-18 18:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 18:46 Emil Velikov [this message]
2023-02-18 18:46 ` [PATCH 01/15] WHENCE: remove trailing white space Emil Velikov
2023-02-18 18:46 ` [PATCH 02/15] WHENCE: remove unnecessary filename quotation Emil Velikov
2023-02-18 18:46 ` [PATCH 03/15] check_whence, WHENCE, copy-firmware: escape filenames with spaces Emil Velikov
2023-02-18 18:46 ` [PATCH 04/15] WHENCE: remove duplicate File entries Emil Velikov
2023-02-18 18:46 ` [PATCH 05/15] check_whence: error on duplicate file entries Emil Velikov
2023-02-18 18:46 ` [PATCH 06/15] check_whence: error on directory listed as File Emil Velikov
2023-02-18 18:46 ` [PATCH 07/15] copy-firmware: remove non-applicable file presence test Emil Velikov
2023-02-18 18:46 ` [PATCH 08/15] check_whence: error if File: is actually a link Emil Velikov
2023-02-18 18:46 ` [PATCH 09/15] check_whence: error if symlinks are in-tree Emil Velikov
2023-02-18 18:46 ` [PATCH 10/15] copy-firmware: remove unreachable symlink workarounds Emil Velikov
2023-02-18 18:46 ` [PATCH 11/15] copy-firmware: quote deskdir to prevent word splitting Emil Velikov
2023-02-18 18:46 ` [PATCH 12/15] copy-firmware: tweak sed invocation Emil Velikov
2023-02-18 18:46 ` [PATCH 13/15] copy-firmware: quote the output of dirname Emil Velikov
2023-02-18 18:46 ` [PATCH 14/15] copy-firmware: silence the last shellcheck warnings Emil Velikov
2023-02-18 18:46 ` [PATCH 15/15] Makefile, copy-firmware: support xz/zstd compressed firmware Emil Velikov
2023-02-28 14:18 ` [PATCH 00/15] Misc fixes, sanity checks and xz/zstd compression Emil Velikov
2023-02-28 14:36 ` David Woodhouse
2023-02-28 16:46 ` Emil Velikov
2023-02-28 16:48 ` David Woodhouse
2023-02-28 17:02 ` Emil Velikov
2023-02-28 17:03 ` David Woodhouse
2023-02-28 17:20 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230218184621.2026504-1-emil.l.velikov@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=linux-firmware@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).