Linux-Firmware Archive on lore.kernel.org
 help / color / Atom feed
From: Jeremy Linton <jeremy.linton@arm.com>
To: Peter Robinson <pbrobinson@gmail.com>, Josh Boyer <jwboyer@kernel.org>
Cc: Linux Firmware <linux-firmware@kernel.org>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string
Date: Sun, 10 Jan 2021 19:59:53 -0600
Message-ID: <2b85361a-ce9e-27bc-5a2d-d6e8e9660e7a@arm.com> (raw)
In-Reply-To: <CALeDE9P+KLXx4qhJs520K+AYkWwOgNEGgMEo2XnZgcLnr=hMuQ@mail.gmail.com>

Hi,

On 1/9/21 7:09 AM, Peter Robinson wrote:
> On Sat, Jan 9, 2021 at 12:34 PM Josh Boyer <jwboyer@kernel.org> wrote:
>>
>> On Fri, Jan 8, 2021 at 6:35 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>>>
>>> On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
>>>>
>>>> The rpi4 when booted with a full featured
>>>> firmware reports a machine id from SMBIOS/DMI.
>>>> Since that is used to select the firmware we
>>>> need to add a new symlink.
>>>
>>> Overall the patch is fine but the commit message is very opinionated
>>> for a wifi firmware support patch. For one it's not a newer DMI string
>>> for Raspberry Pi as all current strings are for device tree and in the
>>> context of supporting WiFi the difference between what ever the
>>> firmware you're referring to when you say "full featured firmware" is
>>> irrelevant and marketing, does that "full featured firmware" support
>>> more features of the wifi chipset than the other variants of firmware?
>>>
>>> Except for the commit message:
>>> Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
>>
>> Not sure what I'm going to do with that.  Do you have a better commit
>> message you'd like to suggest, or are your objections not strong
>> enough to warrant a rewrite?
> 
> How about:
> brcm: Add link for Raspberry Pi 4 for matching DMI string
> 
> When the Raspberry Pi 4 is booted using a ACPI firmware
> the wireless driver matches against a DMI string so
> add a link to ensure the wireless works with that firmware
> variant as well.
> 

I will come up with something and re-post it tomorrow, although I think 
Peter needs to read it with a more euphemistic tone... :)




      reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 20:49 Jeremy Linton
2021-01-08 22:07 ` Hans de Goede
2021-01-08 23:18 ` Jeremy Linton
2021-01-08 23:35 ` Peter Robinson
2021-01-09 12:33   ` Josh Boyer
2021-01-09 13:09     ` Peter Robinson
2021-01-11  1:59       ` Jeremy Linton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b85361a-ce9e-27bc-5a2d-d6e8e9660e7a@arm.com \
    --to=jeremy.linton@arm.com \
    --cc=hdegoede@redhat.com \
    --cc=jwboyer@kernel.org \
    --cc=linux-firmware@kernel.org \
    --cc=pbrobinson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Firmware Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-firmware/0 linux-firmware/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-firmware linux-firmware/ https://lore.kernel.org/linux-firmware \
		linux-firmware@kernel.org
	public-inbox-index linux-firmware

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.lore.linux-firmware


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git