linux-firmware.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: jlinton <jeremy.linton@arm.com>, linux-firmware@kernel.org
Cc: Peter Robinson <pbrobinson@gmail.com>, Josh Boyer <jwboyer@kernel.org>
Subject: Re: [PATCH] brcm: Link CM4's WiFi firmware with DMI machine name.
Date: Thu, 8 Apr 2021 11:15:33 +0200	[thread overview]
Message-ID: <3a446883-958d-4465-0a68-6b757ad2d694@redhat.com> (raw)
In-Reply-To: <20210408032554.5836-1-jeremy.linton@arm.com>

Hi,

On 4/8/21 5:25 AM, jlinton wrote:
> From: Jeremy Linton <jeremy.linton@arm.com>
> 
> The kernel when booted in ACPI mode with SMBIOS/DMI
> data uses the DMI data to set the machine
> manufacture/model.
> 
> The WiFi driver uses the machine string to select the
> correct firmware image. Because of this, an additional
> link to select the correct firmware is needed.
> 
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Peter Robinson <pbrobinson@gmail.com>
> Cc: Josh Boyer <jwboyer@kernel.org>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  WHENCE | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/WHENCE b/WHENCE
> index aa96404..1eaee0b 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2723,6 +2723,7 @@ File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
>  Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
>  Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> +Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ Compute\ Module\ 4.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
>  File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
>  File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
>  File: brcm/brcmfmac4356-sdio.vamrs,rock960.txt
> 


  reply	other threads:[~2021-04-08  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  3:25 [PATCH] brcm: Link CM4's WiFi firmware with DMI machine name jlinton
2021-04-08  9:15 ` Hans de Goede [this message]
2021-04-19 13:51   ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a446883-958d-4465-0a68-6b757ad2d694@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=jeremy.linton@arm.com \
    --cc=jwboyer@kernel.org \
    --cc=linux-firmware@kernel.org \
    --cc=pbrobinson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).