Linux-Firmware Archive on
 help / color / Atom feed
From: Tomi Valkeinen <>
To: Laurent Pinchart <>,
	Nikhil Devshatwar <>
Cc: <>, <>,
	Dan Murphy <>, Benoit Parrot <>,
	Sekhar Nori <>
Subject: Re: [PATCH] vpdma: Move firmware to the toplevel
Date: Wed, 28 Oct 2020 09:41:39 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On 26/10/2020 23:08, Laurent Pinchart wrote:
> Hi Nikhil,
> Thank you for the patch.
> On Tue, Oct 27, 2020 at 01:39:22AM +0530, Nikhil Devshatwar wrote:
>> Move the vpdma firmware to the toplevel directory so
>> that the existing drivers can use it with the same path.
>> Fixes: 5b30b383ce ("linux-firmware: Add new VPDMA firmware 1b8.bin")
>> Signed-off-by: Nikhil Devshatwar <>
>> ---
>>  WHENCE                                         |   2 +-
>>  ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin | Bin
> I think Tomi meant moving the file to ti/ instead of ti-connectivity/. I
> will let him comment on this.

I don't really have a strong opinion here, as I don't know if there are some rules or guidelines
about file/dir naming in linux-firmware.

But my argument is:

The fw should either be at the root dir, where the linux driver is already looking for it, OR, if we
do move it somewhere, move it to a "right" place. Afaics "ti-connectivity" is totally wrong place,
as vpdma has nothing to do with connectivity.

The root dir is a bit bad as "vpdma-1b8.bin" doesn't have TI or such in its name, so even if name
conflict with some other fw feels quite unlikely, the name is still rather vague. And moving is a
bit bad as then the current driver won't find the fw...


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 20:09 Nikhil Devshatwar
2020-10-26 21:08 ` Laurent Pinchart
2020-10-28  7:41   ` Tomi Valkeinen [this message]
2020-10-28 17:19     ` Nikhil Devshatwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Firmware Archive on

Archives are clonable:
	git clone --mirror linux-firmware/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-firmware linux-firmware/ \
	public-inbox-index linux-firmware

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone