From: Kalle Valo <kvalo@codeaurora.org>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: Josh Boyer <jwboyer@kernel.org>,
Linux Wireless <linux-wireless@vger.kernel.org>,
ath10k@lists.infradead.org,
Linux Firmware <linux-firmware@kernel.org>
Subject: Re: [PATCH] ath10k: add SDIO firmware for QCA9377 WiFi
Date: Mon, 25 May 2020 14:53:10 +0300 [thread overview]
Message-ID: <871rn89qop.fsf@codeaurora.org> (raw)
In-Reply-To: <37BB0344-C9EB-41F5-87E7-D66DA45A488E@gmail.com> (Christian Hewitt's message of "Mon, 25 May 2020 09:09:35 +0400")
Christian Hewitt <christianshewitt@gmail.com> writes:
>> On 24 May 2020, at 8:34 pm, Josh Boyer <jwboyer@kernel.org> wrote:
>>
>> On Sun, May 24, 2020 at 9:59 AM Christian Hewitt
>> <christianshewitt@gmail.com> wrote:
>>>
>>> This commit adds the SDIO firmware for ath10k/QCA9377 cards. The file
>>> is from the Boundary Devices repo [1] and has the same license as the
>>> existing firmware-5.bin file. Support for QCA9377 WiFi was merged for
>>> Linux 5.7 [2].
>>>
>>> [1] https://github.com/boundarydevices/qca-firmware/tree/bd-sdmac-ath10k
>>> [2]
>>> https://github.com/torvalds/linux/commit/6e51b0e4913ca2c93059f73ca477ca30ea95b6a0
>>
>> That repo got it from Kalle's untested repo, and didn't carry over the
>> Signed-off-by. You didn't carry over the Signed-off-by from the repo
>> you got it from. 3 levels of indirection to include a file with a
>> giant notice from an untested sources is a bit too much for me to feel
>> comfortable with.
>
> Apologies Josh, I have been using my own repack of the Boundary Devices
> repo and had completely forgotten Kalle’s repo existed and was the
> original source of the file.
>
>> Kalle, is there a reason you didn't send this upstream 3 years ago?
>
> SDIO support is a relatively recent addition to the ath10k driver and
> the commit message in this RFT [1] probably explains why his repo has
> it described as untested.
>
> I’m happy to submit v2 with corrected references or let Kalle handle
> the submission, whichever is best or easiest is fine with me.
I'll include the QCA9377 SDIO image in my next pull request to Josh.
I'll also have QCA6174 SDIO images pending.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-25 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 13:59 [PATCH] ath10k: add SDIO firmware for QCA9377 WiFi Christian Hewitt
2020-05-24 13:59 ` Christian Hewitt
2020-05-24 16:34 ` Josh Boyer
2020-05-25 5:09 ` Christian Hewitt
2020-05-25 5:09 ` Christian Hewitt
2020-05-25 11:53 ` Kalle Valo [this message]
2020-05-25 11:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rn89qop.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=christianshewitt@gmail.com \
--cc=jwboyer@kernel.org \
--cc=linux-firmware@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).