linux-firmware.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pkshih <pkshih@realtek.com>
To: Kalle Valo <kvalo@codeaurora.org>,
	Brian Norris <briannorris@chromium.org>
Cc: "linux-firmware@kernel.org" <linux-firmware@kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: Request to update 8852a firmware of rtw89 to v0.13.8.0
Date: Thu, 13 May 2021 09:38:01 +0000	[thread overview]
Message-ID: <876c29841fcf4d21ab2440cbb5879de2@realtek.com> (raw)
In-Reply-To: <87tun7i2rn.fsf@codeaurora.org>



> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
> Behalf Of Kalle Valo
> Sent: Thursday, May 13, 2021 2:09 PM
> To: Brian Norris
> Cc: Pkshih; linux-firmware@kernel.org; linux-wireless@vger.kernel.org
> Subject: Re: Request to update 8852a firmware of rtw89 to v0.13.8.0
> 
> Brian Norris <briannorris@chromium.org> writes:
> 
> > On Tue, May 11, 2021 at 11:05 AM Kalle Valo <kvalo@codeaurora.org> wrote:
> >>
> >> Pkshih <pkshih@realtek.com> writes:
> >>
> >> > Please help to update 8852a firmware.
> >> > This is first time I send a pull request. If anything is wrong,
> >> > please let me know.
> >>
> >> rtw89 driver is not in upstream yet, and it has not been reviewed
> >> either. I recommend holding off pulling the firmware until the driver is
> >> reviewed.
> >
> > FWIW, preliminary rtw89 firmware was already merged. This is just an update.
> >
> > I also wonder, what's the harm? People like me are actively testing
> > the early versions, and I've done a very barebones amount of review (I
> > hope to do more). It really helps me to have up-to-date firmware
> > published somewhere central -- I guess I can take GitHub instead, but
> > again, why not kernel.org? If anyone else is looking at testing, they
> > know where to get the pieces too, and we can compare results.
> 
> It can create confusion to the users if during review we make changes
> how firmware files are handled. Some drivers have windows style .ini
> files which are not ok in an upstream driver, there could be changes in
> the file format etc.
> 
> But I have no strong opinion here, my main motivation is just to try to
> keep things simple for maintaining the "interface" between
> linux-firmware and kernel wireless drivers. My preference is that the
> firmware files are ready for submission when a new driver is submitted
> for review, but the firmware files are submitted only after the driver
> is accepted.
> 

I think I can maintain the firmware in GitHub before driver is accepted,
and add some information about firmware version and link in the cover of
patchset. Then, people can take proper firmware.

--
Ping-Ke



  parent reply	other threads:[~2021-05-13  9:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  8:59 Request to update 8852a firmware of rtw89 to v0.13.8.0 Pkshih
2021-05-03 13:17 ` Josh Boyer
2021-05-11 18:05 ` Kalle Valo
2021-05-11 18:05   ` Kalle Valo
2021-05-11 18:09   ` Josh Boyer
2021-05-11 19:10   ` Brian Norris
2021-05-11 19:10     ` Brian Norris
2021-05-13  6:09     ` Kalle Valo
2021-05-13  6:09       ` Kalle Valo
2021-05-13  9:38       ` Pkshih [this message]
2021-05-13 21:08         ` Brian Norris
2021-05-13 21:08           ` Brian Norris
2021-05-14  6:22           ` Kalle Valo
2021-05-14  6:22             ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876c29841fcf4d21ab2440cbb5879de2@realtek.com \
    --to=pkshih@realtek.com \
    --cc=briannorris@chromium.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-firmware@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).