From: "K, Kiran" <kiran.k@intel.com>
To: "linux-firmware@kernel.org" <linux-firmware@kernel.org>
Cc: "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
"Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
"Narasimman, Sathish" <sathish.narasimman@intel.com>
Subject: RE: [PATCH v8 1/5] Bluetooth: btintel: Fix endianness issue for TLV version information
Date: Thu, 19 Nov 2020 11:36:56 +0000
Message-ID: <BYAPR11MB314132F885B4EA68DC4C31F2F5E00@BYAPR11MB3141.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201119113450.13771-1-kiran.k@intel.com>
Hi,
Please ignore this patchset. By mistake I sent to the incorrect mailing list.
Thanks,
Kiran
> -----Original Message-----
> From: K, Kiran <kiran.k@intel.com>
> Sent: Thursday, November 19, 2020 5:05 PM
> To: linux-firmware@kernel.org
> Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@intel.com>; Tumkur
> Narayan, Chethan <chethan.tumkur.narayan@intel.com>; Narasimman,
> Sathish <sathish.narasimman@intel.com>; K, Kiran <kiran.k@intel.com>
> Subject: [PATCH v8 1/5] Bluetooth: btintel: Fix endianness issue for TLV
> version information
>
> do __le32_to_cpu to tlv data fields to make sure driver runs correctly when
> running on big endian system.
>
> Signed-off-by: Kiran K <kiran.k@intel.com>
> Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
> ---
> drivers/bluetooth/btintel.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index
> 88ce5f0ffc4b..41ff2071d7ef 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -437,31 +437,38 @@ int btintel_read_version_tlv(struct hci_dev *hdev,
> struct intel_version_tlv *ver
> tlv = (struct intel_tlv *)skb->data;
> switch (tlv->type) {
> case INTEL_TLV_CNVI_TOP:
> - version->cnvi_top = get_unaligned_le32(tlv->val);
> + version->cnvi_top =
> + __le32_to_cpu(get_unaligned_le32(tlv->val));
> break;
> case INTEL_TLV_CNVR_TOP:
> - version->cnvr_top = get_unaligned_le32(tlv->val);
> + version->cnvr_top =
> + __le32_to_cpu(get_unaligned_le32(tlv->val));
> break;
> case INTEL_TLV_CNVI_BT:
> - version->cnvi_bt = get_unaligned_le32(tlv->val);
> + version->cnvi_bt =
> + __le32_to_cpu(get_unaligned_le32(tlv->val));
> break;
> case INTEL_TLV_CNVR_BT:
> - version->cnvr_bt = get_unaligned_le32(tlv->val);
> + version->cnvr_bt =
> + __le32_to_cpu(get_unaligned_le32(tlv->val));
> break;
> case INTEL_TLV_DEV_REV_ID:
> - version->dev_rev_id = get_unaligned_le16(tlv->val);
> + version->dev_rev_id =
> + __le16_to_cpu(get_unaligned_le16(tlv->val));
> break;
> case INTEL_TLV_IMAGE_TYPE:
> version->img_type = tlv->val[0];
> break;
> case INTEL_TLV_TIME_STAMP:
> - version->timestamp = get_unaligned_le16(tlv->val);
> + version->timestamp =
> + __le16_to_cpu(get_unaligned_le16(tlv->val));
> break;
> case INTEL_TLV_BUILD_TYPE:
> version->build_type = tlv->val[0];
> break;
> case INTEL_TLV_BUILD_NUM:
> - version->build_num = get_unaligned_le32(tlv->val);
> + version->build_num =
> + __le32_to_cpu(get_unaligned_le32(tlv->val));
> break;
> case INTEL_TLV_SECURE_BOOT:
> version->secure_boot = tlv->val[0];
> --
> 2.17.1
prev parent reply index
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 11:34 Kiran K
2020-11-19 11:34 ` [PATCH v8 2/5] Bluetooth: btusb: Add *setup* function for new generation Intel controllers Kiran K
2020-11-19 11:34 ` [PATCH v8 3/5] Bluetooth: btusb: Define a function to construct firmware filename Kiran K
2020-11-19 11:34 ` [PATCH v8 4/5] Bluetooth: btusb: Helper function to download firmware to Intel adapters Kiran K
2020-11-19 11:34 ` [PATCH v8 5/5] Bluetooth: btusb: Map Typhoon peak controller to BTUSB_INTEL_NEWGEN Kiran K
2020-11-19 11:36 ` K, Kiran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB314132F885B4EA68DC4C31F2F5E00@BYAPR11MB3141.namprd11.prod.outlook.com \
--to=kiran.k@intel.com \
--cc=chethan.tumkur.narayan@intel.com \
--cc=linux-firmware@kernel.org \
--cc=ravishankar.srivatsa@intel.com \
--cc=sathish.narasimman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Firmware Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-firmware/0 linux-firmware/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-firmware linux-firmware/ https://lore.kernel.org/linux-firmware \
linux-firmware@kernel.org
public-inbox-index linux-firmware
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.lore.linux-firmware
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git