linux-firmware.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] brcm: Link CM4's WiFi firmware with DMI machine name.
@ 2021-04-08  3:25 jlinton
  2021-04-08  9:15 ` Hans de Goede
  0 siblings, 1 reply; 3+ messages in thread
From: jlinton @ 2021-04-08  3:25 UTC (permalink / raw)
  To: linux-firmware; +Cc: Jeremy Linton, Hans de Goede, Peter Robinson, Josh Boyer

From: Jeremy Linton <jeremy.linton@arm.com>

The kernel when booted in ACPI mode with SMBIOS/DMI
data uses the DMI data to set the machine
manufacture/model.

The WiFi driver uses the machine string to select the
correct firmware image. Because of this, an additional
link to select the correct firmware is needed.

Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Peter Robinson <pbrobinson@gmail.com>
Cc: Josh Boyer <jwboyer@kernel.org>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 WHENCE | 1 +
 1 file changed, 1 insertion(+)

diff --git a/WHENCE b/WHENCE
index aa96404..1eaee0b 100644
--- a/WHENCE
+++ b/WHENCE
@@ -2723,6 +2723,7 @@ File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
 Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
 File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
 Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
+Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ Compute\ Module\ 4.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
 File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
 File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
 File: brcm/brcmfmac4356-sdio.vamrs,rock960.txt
-- 
2.29.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] brcm: Link CM4's WiFi firmware with DMI machine name.
  2021-04-08  3:25 [PATCH] brcm: Link CM4's WiFi firmware with DMI machine name jlinton
@ 2021-04-08  9:15 ` Hans de Goede
  2021-04-19 13:51   ` Josh Boyer
  0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2021-04-08  9:15 UTC (permalink / raw)
  To: jlinton, linux-firmware; +Cc: Peter Robinson, Josh Boyer

Hi,

On 4/8/21 5:25 AM, jlinton wrote:
> From: Jeremy Linton <jeremy.linton@arm.com>
> 
> The kernel when booted in ACPI mode with SMBIOS/DMI
> data uses the DMI data to set the machine
> manufacture/model.
> 
> The WiFi driver uses the machine string to select the
> correct firmware image. Because of this, an additional
> link to select the correct firmware is needed.
> 
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Peter Robinson <pbrobinson@gmail.com>
> Cc: Josh Boyer <jwboyer@kernel.org>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  WHENCE | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/WHENCE b/WHENCE
> index aa96404..1eaee0b 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2723,6 +2723,7 @@ File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
>  Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
>  Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> +Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ Compute\ Module\ 4.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
>  File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
>  File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
>  File: brcm/brcmfmac4356-sdio.vamrs,rock960.txt
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] brcm: Link CM4's WiFi firmware with DMI machine name.
  2021-04-08  9:15 ` Hans de Goede
@ 2021-04-19 13:51   ` Josh Boyer
  0 siblings, 0 replies; 3+ messages in thread
From: Josh Boyer @ 2021-04-19 13:51 UTC (permalink / raw)
  To: Hans de Goede; +Cc: jlinton, Linux Firmware, Peter Robinson

Applied and pushed out.

josh

On Thu, Apr 8, 2021 at 5:15 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 4/8/21 5:25 AM, jlinton wrote:
> > From: Jeremy Linton <jeremy.linton@arm.com>
> >
> > The kernel when booted in ACPI mode with SMBIOS/DMI
> > data uses the DMI data to set the machine
> > manufacture/model.
> >
> > The WiFi driver uses the machine string to select the
> > correct firmware image. Because of this, an additional
> > link to select the correct firmware is needed.
> >
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Peter Robinson <pbrobinson@gmail.com>
> > Cc: Josh Boyer <jwboyer@kernel.org>
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
>
>
>
> > ---
> >  WHENCE | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/WHENCE b/WHENCE
> > index aa96404..1eaee0b 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -2723,6 +2723,7 @@ File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
> >  Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
> >  File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
> >  Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> > +Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ Compute\ Module\ 4.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> >  File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
> >  File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
> >  File: brcm/brcmfmac4356-sdio.vamrs,rock960.txt
> >
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-19 13:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08  3:25 [PATCH] brcm: Link CM4's WiFi firmware with DMI machine name jlinton
2021-04-08  9:15 ` Hans de Goede
2021-04-19 13:51   ` Josh Boyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).