From: Josh Boyer <jwboyer@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>,
Linux Firmware <linux-firmware@kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string
Date: Sat, 9 Jan 2021 07:33:51 -0500 [thread overview]
Message-ID: <CA+5PVA5uogMz53S+gaBGVC5E=miJjDoa+sbRjmubcFXPueOzGQ@mail.gmail.com> (raw)
In-Reply-To: <CALeDE9M4YZc9Wga5DvUebr4bgM8z3E-Aa7V-WoKxy01GfkaCSw@mail.gmail.com>
On Fri, Jan 8, 2021 at 6:35 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > The rpi4 when booted with a full featured
> > firmware reports a machine id from SMBIOS/DMI.
> > Since that is used to select the firmware we
> > need to add a new symlink.
>
> Overall the patch is fine but the commit message is very opinionated
> for a wifi firmware support patch. For one it's not a newer DMI string
> for Raspberry Pi as all current strings are for device tree and in the
> context of supporting WiFi the difference between what ever the
> firmware you're referring to when you say "full featured firmware" is
> irrelevant and marketing, does that "full featured firmware" support
> more features of the wifi chipset than the other variants of firmware?
>
> Except for the commit message:
> Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
Not sure what I'm going to do with that. Do you have a better commit
message you'd like to suggest, or are your objections not strong
enough to warrant a rewrite?
josh
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> > ---
> > WHENCE | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/WHENCE b/WHENCE
> > index cbde48d..1f69078 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -2711,6 +2711,7 @@ File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
> > File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
> > Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
> > File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
> > +Link: brcm/brcmfmac43455-sdio.Raspberryi\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> > File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
> > File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
> >
> > --
> > 2.26.2
> >
next prev parent reply other threads:[~2021-01-09 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 20:49 [PATCH] brcm: Link rpi4's wifi with newer DMI string Jeremy Linton
2021-01-08 22:07 ` Hans de Goede
2021-01-08 23:18 ` Jeremy Linton
2021-01-08 23:35 ` Peter Robinson
2021-01-09 12:33 ` Josh Boyer [this message]
2021-01-09 13:09 ` Peter Robinson
2021-01-11 1:59 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+5PVA5uogMz53S+gaBGVC5E=miJjDoa+sbRjmubcFXPueOzGQ@mail.gmail.com' \
--to=jwboyer@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jeremy.linton@arm.com \
--cc=linux-firmware@kernel.org \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).