[PATCH] Add symlink for Dell XPS 15 9550 Broadcom Bluetooth patch-ram file

[PATCH] Add symlink for Dell XPS 15 9550 Broadcom Bluetooth patch-ram file

[Hans de Goede]

The linux-firmware repo does not contain many Broadcom (now Cypress)
Bluetooth patch-ram files, because we have never been able to get
permission to re-distribute those.

We do have one file for the for HTC Vive, which was submitted by HTC
themselves with permission from Cypress.

That file contain a "BCM20703A1 Generic USB 20Mhz fcbga_BU" patch-ram
build. The patch-ram files used by Windows for the Bluetooth module
in the XPS 15 9550, USB-id 0a5c:6410 is also a "BCM20703A1 Generic
USB 20Mhz fcbga_BU" patch-ram build. Since the build-parameters
(crystal MHz, package/module type used) between the 2 builds are an
exact match we can also use the HTC submitted patch-ram for the
XPS 15 9550. So lets add a symlink for this.

This will make the Bluetooth on the XPS 15 9550 work out of the box,
when linux-firmware is installed, without the user needing to go and
find a suitable patch-ram file themselves.

This has been tested on a XPS 15 9550 with both Bluetooth HID and
Bluetooth audio devices.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 WHENCE                 | 1 +
 brcm/BCM-0a5c-6410.hcd | 1 +
 2 files changed, 2 insertions(+)
 create mode 120000 brcm/BCM-0a5c-6410.hcd

diff --git a/WHENCE b/WHENCE
index 893586e..e3bab8b 100644
--- a/WHENCE
+++ b/WHENCE
@@ -10,6 +10,7 @@ kernel.
 
 Driver: BCM-0bb4-0306 Cypress Bluetooth firmware for HTC Vive
 
+File: brcm/BCM-0a5c-6410.hcd
 File: brcm/BCM-0bb4-0306.hcd
 
 Licence: Redistributable. See LICENCE.cypress for details.
diff --git a/brcm/BCM-0a5c-6410.hcd b/brcm/BCM-0a5c-6410.hcd
new file mode 120000
index 0000000..df02293
--- /dev/null
+++ b/brcm/BCM-0a5c-6410.hcd
@@ -0,0 +1 @@
+BCM-0bb4-0306.hcd
\ No newline at end of file
-- 
2.26.0

Re: [PATCH] Add symlink for Dell XPS 15 9550 Broadcom Bluetooth patch-ram file

[Josh Boyer]

On Fri, Apr 17, 2020 at 12:20 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The linux-firmware repo does not contain many Broadcom (now Cypress)
> Bluetooth patch-ram files, because we have never been able to get
> permission to re-distribute those.
>
> We do have one file for the for HTC Vive, which was submitted by HTC
> themselves with permission from Cypress.
>
> That file contain a "BCM20703A1 Generic USB 20Mhz fcbga_BU" patch-ram
> build. The patch-ram files used by Windows for the Bluetooth module
> in the XPS 15 9550, USB-id 0a5c:6410 is also a "BCM20703A1 Generic
> USB 20Mhz fcbga_BU" patch-ram build. Since the build-parameters
> (crystal MHz, package/module type used) between the 2 builds are an
> exact match we can also use the HTC submitted patch-ram for the
> XPS 15 9550. So lets add a symlink for this.
>
> This will make the Bluetooth on the XPS 15 9550 work out of the box,
> when linux-firmware is installed, without the user needing to go and
> find a suitable patch-ram file themselves.
>
> This has been tested on a XPS 15 9550 with both Bluetooth HID and
> Bluetooth audio devices.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  WHENCE                 | 1 +
>  brcm/BCM-0a5c-6410.hcd | 1 +
>  2 files changed, 2 insertions(+)
>  create mode 120000 brcm/BCM-0a5c-6410.hcd

It should be possible to do this by simply using the Link directive in
the WHENCE file.  That will create the symlink at installation time.
It's a fairly recent enhancement.  I'll look at it tomorrow and adjust
if so.

josh

Re: [PATCH] Add symlink for Dell XPS 15 9550 Broadcom Bluetooth patch-ram file

[Hans de Goede]

Hi,

On 4/21/20 12:31 AM, Josh Boyer wrote:
> On Fri, Apr 17, 2020 at 12:20 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> The linux-firmware repo does not contain many Broadcom (now Cypress)
>> Bluetooth patch-ram files, because we have never been able to get
>> permission to re-distribute those.
>>
>> We do have one file for the for HTC Vive, which was submitted by HTC
>> themselves with permission from Cypress.
>>
>> That file contain a "BCM20703A1 Generic USB 20Mhz fcbga_BU" patch-ram
>> build. The patch-ram files used by Windows for the Bluetooth module
>> in the XPS 15 9550, USB-id 0a5c:6410 is also a "BCM20703A1 Generic
>> USB 20Mhz fcbga_BU" patch-ram build. Since the build-parameters
>> (crystal MHz, package/module type used) between the 2 builds are an
>> exact match we can also use the HTC submitted patch-ram for the
>> XPS 15 9550. So lets add a symlink for this.
>>
>> This will make the Bluetooth on the XPS 15 9550 work out of the box,
>> when linux-firmware is installed, without the user needing to go and
>> find a suitable patch-ram file themselves.
>>
>> This has been tested on a XPS 15 9550 with both Bluetooth HID and
>> Bluetooth audio devices.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   WHENCE                 | 1 +
>>   brcm/BCM-0a5c-6410.hcd | 1 +
>>   2 files changed, 2 insertions(+)
>>   create mode 120000 brcm/BCM-0a5c-6410.hcd
> 
> It should be possible to do this by simply using the Link directive in
> the WHENCE file.  That will create the symlink at installation time.
> It's a fairly recent enhancement.  I'll look at it tomorrow and adjust
> if so.

Nice, that would indeed be an improvement as in the past make install
turned the symlinks into file copies IIRC.

Perhaps you can also convert the brcm/brcmfmac43362-sdio.lemaker,bananapro.txt
symlink to use this new method?

Thank you for taking care of adjusting the patch.

Regards,

Hans

Re: [PATCH] Add symlink for Dell XPS 15 9550 Broadcom Bluetooth patch-ram file

[Josh Boyer]

On Tue, Apr 21, 2020 at 3:46 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 4/21/20 12:31 AM, Josh Boyer wrote:
> > On Fri, Apr 17, 2020 at 12:20 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >>
> >> The linux-firmware repo does not contain many Broadcom (now Cypress)
> >> Bluetooth patch-ram files, because we have never been able to get
> >> permission to re-distribute those.
> >>
> >> We do have one file for the for HTC Vive, which was submitted by HTC
> >> themselves with permission from Cypress.
> >>
> >> That file contain a "BCM20703A1 Generic USB 20Mhz fcbga_BU" patch-ram
> >> build. The patch-ram files used by Windows for the Bluetooth module
> >> in the XPS 15 9550, USB-id 0a5c:6410 is also a "BCM20703A1 Generic
> >> USB 20Mhz fcbga_BU" patch-ram build. Since the build-parameters
> >> (crystal MHz, package/module type used) between the 2 builds are an
> >> exact match we can also use the HTC submitted patch-ram for the
> >> XPS 15 9550. So lets add a symlink for this.
> >>
> >> This will make the Bluetooth on the XPS 15 9550 work out of the box,
> >> when linux-firmware is installed, without the user needing to go and
> >> find a suitable patch-ram file themselves.
> >>
> >> This has been tested on a XPS 15 9550 with both Bluetooth HID and
> >> Bluetooth audio devices.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >> ---
> >>   WHENCE                 | 1 +
> >>   brcm/BCM-0a5c-6410.hcd | 1 +
> >>   2 files changed, 2 insertions(+)
> >>   create mode 120000 brcm/BCM-0a5c-6410.hcd
> >
> > It should be possible to do this by simply using the Link directive in
> > the WHENCE file.  That will create the symlink at installation time.
> > It's a fairly recent enhancement.  I'll look at it tomorrow and adjust
> > if so.
>
> Nice, that would indeed be an improvement as in the past make install
> turned the symlinks into file copies IIRC.
>
> Perhaps you can also convert the brcm/brcmfmac43362-sdio.lemaker,bananapro.txt
> symlink to use this new method?

Both done and pushed out.

josh