linux-firmware.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>,
	Linux Firmware <linux-firmware@kernel.org>,
	 Peter Robinson <pbrobinson@gmail.com>,
	Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Subject: Re: [BUG] cypress: Fix link direction
Date: Fri, 8 Jan 2021 19:33:49 -0500	[thread overview]
Message-ID: <CA+5PVA6qHXe+t23vGUv+8=pqGjG0-=op4QwgUT2-D_+jy73eUw@mail.gmail.com> (raw)
In-Reply-To: <136e2055-c307-5097-385c-fb9a741d9672@redhat.com>

On Fri, Jan 8, 2021 at 5:08 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 1/8/21 9:44 PM, Jeremy Linton wrote:
> > It appears the link direction was incorrect resulting
> > in dangling symlinks. This also causes the brcm devices
> > to be unable to find their firmware
> >
> > Fixes: 060ad8b3d505e ("cypress: Link the new cypress firmware to the old brcm files")
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> > Cc: Peter Robinson <pbrobinson@gmail.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> > Cc: Josh Boyer <jwboyer@kernel.org>
>
> <ugh>, thank you for catching this.

Indeed.  I should have caught this as well.  Thank you.

Patch applied and pushed out.  I'll get to the rest tomorrow.

josh

> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
>
> > ---
> >  WHENCE | 42 +++++++++++++++++++++---------------------
> >  1 file changed, 21 insertions(+), 21 deletions(-)
> >
> > diff --git a/WHENCE b/WHENCE
> > index 676bb18..cbde48d 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -2651,47 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details.
> >
> >  File: brcm/brcmfmac4373.bin
> >  File: cypress/cyfmac43012-sdio.bin
> > -Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin
> > +Link: brcm/brcmfmac43012-sdio.bin -> ../cypress/cyfmac43012-sdio.bin
> >  File: cypress/cyfmac43012-sdio.clm_blob
> > -Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob
> > +Link: brcm/brcmfmac43012-sdio.clm_blob -> ../cypress/cyfmac43012-sdio.clm_blob
> >  File: cypress/cyfmac43340-sdio.bin
> > -Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin
> > +Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin
> >  File: cypress/cyfmac43362-sdio.bin
> > -Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin
> > +Link: brcm/brcmfmac43362-sdio.bin -> ../cypress/cyfmac43362-sdio.bin
> >  File: cypress/cyfmac4339-sdio.bin
> > -Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin
> > +Link: brcm/brcmfmac4339-sdio.bin -> ../cypress/cyfmac4339-sdio.bin
> >  File: cypress/cyfmac43430-sdio.bin
> > -Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin
> > +Link: brcm/brcmfmac43430-sdio.bin -> ../cypress/cyfmac43430-sdio.bin
> >  File: cypress/cyfmac43430-sdio.clm_blob
> > -Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob
> > +Link: brcm/brcmfmac43430-sdio.clm_blob -> ../cypress/cyfmac43430-sdio.clm_blob
> >  File: cypress/cyfmac43455-sdio.bin
> > -Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin
> > +Link: brcm/brcmfmac43455-sdio.bin -> ../cypress/cyfmac43455-sdio.bin
> >  File: cypress/cyfmac43455-sdio.clm_blob
> > -Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob
> > +Link: brcm/brcmfmac43455-sdio.clm_blob -> ../cypress/cyfmac43455-sdio.clm_blob
> >  File: cypress/cyfmac4354-sdio.bin
> > -Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin
> > +Link: brcm/brcmfmac4354-sdio.bin -> ../cypress/cyfmac4354-sdio.bin
> >  File: cypress/cyfmac4354-sdio.clm_blob
> > -Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob
> > +Link: brcm/brcmfmac4354-sdio.clm_blob -> ../cypress/cyfmac4354-sdio.clm_blob
> >  File: cypress/cyfmac4356-pcie.bin
> > -Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin
> > +Link: brcm/brcmfmac4356-pcie.bin -> ../cypress/cyfmac4356-pcie.bin
> >  File: cypress/cyfmac4356-pcie.clm_blob
> > -Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob
> > +Link: brcm/brcmfmac4356-pcie.clm_blob -> ../cypress/cyfmac4356-pcie.clm_blob
> >  File: cypress/cyfmac4356-sdio.bin
> > -Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin
> > +Link: brcm/brcmfmac4356-sdio.bin -> ../cypress/cyfmac4356-sdio.bin
> >  File: cypress/cyfmac4356-sdio.clm_blob
> > -Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob
> > +Link: brcm/brcmfmac4356-sdio.clm_blob -> ../cypress/cyfmac4356-sdio.clm_blob
> >  File: cypress/cyfmac43570-pcie.bin
> > -Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin
> > +Link: brcm/brcmfmac43570-pcie.bin -> ../cypress/cyfmac43570-pcie.bin
> >  File: cypress/cyfmac43570-pcie.clm_blob
> > -Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob
> > +Link: brcm/brcmfmac43570-pcie.clm_blob -> ../cypress/cyfmac43570-pcie.clm_blob
> >  File: cypress/cyfmac4373-sdio.bin
> > -Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin
> > +Link: brcm/brcmfmac4373-sdio.bin -> ../cypress/cyfmac4373-sdio.bin
> >  File: cypress/cyfmac4373-sdio.clm_blob
> > -Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob
> > +Link: brcm/brcmfmac4373-sdio.clm_blob -> ../cypress/cyfmac4373-sdio.clm_blob
> >  File: cypress/cyfmac54591-pcie.bin
> > -Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin
> > +Link: brcm/brcmfmac54591-pcie.bin -> ../cypress/cyfmac54591-pcie.bin
> >  File: cypress/cyfmac54591-pcie.clm_blob
> > -Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob
> > +Link: brcm/brcmfmac54591-pcie.clm_blob -> ../cypress/cyfmac54591-pcie.clm_blob
> >
> >  Licence: Redistributable. See LICENCE.cypress for details.
> >
> >
>

      reply	other threads:[~2021-01-09  0:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 20:44 [BUG] cypress: Fix link direction Jeremy Linton
2021-01-08 22:08 ` Hans de Goede
2021-01-09  0:33   ` Josh Boyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+5PVA6qHXe+t23vGUv+8=pqGjG0-=op4QwgUT2-D_+jy73eUw@mail.gmail.com' \
    --to=jwboyer@kernel.org \
    --cc=chi-hsien.lin@cypress.com \
    --cc=hdegoede@redhat.com \
    --cc=jeremy.linton@arm.com \
    --cc=linux-firmware@kernel.org \
    --cc=pbrobinson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).