From: Josh Boyer <jwboyer@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Chi-Hsien Lin <Chi-Hsien.Lin@infineon.com>,
Linux Firmware <linux-firmware@kernel.org>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
SHA-cyfmac-dev-list@infineon.com,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 2/2] cyprus: Link the new cyprus firmware to the old brcm files
Date: Thu, 7 Jan 2021 19:52:58 -0500 [thread overview]
Message-ID: <CA+5PVA78OgmYVw6mHgfyjRnSCh=qbzwQ+F-oeUM+aFHeJa5-bw@mail.gmail.com> (raw)
In-Reply-To: <CA+5PVA5+o5Pkui81C_vY+fj0HGwxieDQ4=feoV=nVTk_i-BBCw@mail.gmail.com>
On Wed, Jan 6, 2021 at 7:22 AM Josh Boyer <jwboyer@kernel.org> wrote:
>
> On Wed, Jan 6, 2021 at 4:19 AM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi,
> >
> > On 1/6/21 10:17 AM, Peter Robinson wrote:
> > > On Wed, Jan 6, 2021 at 3:50 AM Chi-Hsien Lin <Chi-Hsien.Lin@infineon.com> wrote:
> > >>
> > >>
> > >> Peter Robinson 於 2021/1/6 上午 12:04 寫道:
> > >>> By linking the new firmware to the old file it allows exisiting
> > >>> kernels to make use of the new firmware and make use of the
> > >>> newer firmware with all the associated fixes.
> > >>>
> > >>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > >>> Cc: Hans de Goede <hdegoede@redhat.com>
> > >>> Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> > >>
> > >> (+Arend and lists)
> > >>
> > >> Hi Peter,
> > >>
> > >> The folder name is Cypress instead of cyprus. Could you please fix this
> > >> in v2 commit messages?
> > >
> > > Yes, of course. I'll wait a little for some other feedback.
> >
> > I thought I already send this yesterday, but I think I did the review and
> > then forgot to reply...
> >
> > The entire series looks good to me, so for v2 you can add my:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > To both patches.
>
> I'll just edit the commit messages locally when I apply the patches.
> No need for a full v2 submission unless there are other changes to be
> made. I'll wait for a bit before committing to allow for any other
> feedback.
Both applied and pushed out.
josh
> > >>> WHENCE | 21 +++++++++++++++++++++
> > >>> 1 file changed, 21 insertions(+)
> > >>>
> > >>> diff --git a/WHENCE b/WHENCE
> > >>> index 1bd5085..354d52a 100644
> > >>> --- a/WHENCE
> > >>> +++ b/WHENCE
> > >>> @@ -2651,26 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details.
> > >>>
> > >>> File: brcm/brcmfmac4373.bin
> > >>> File: cypress/cyfmac43012-sdio.bin
> > >>> +Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin
> > >>> File: cypress/cyfmac43012-sdio.clm_blob
> > >>> +Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob
> > >>> File: cypress/cyfmac43340-sdio.bin
> > >>> +Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin
> > >>> File: cypress/cyfmac43362-sdio.bin
> > >>> +Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin
> > >>> File: cypress/cyfmac4339-sdio.bin
> > >>> +Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin
> > >>> File: cypress/cyfmac43430-sdio.bin
> > >>> +Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin
> > >>> File: cypress/cyfmac43430-sdio.clm_blob
> > >>> +Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob
> > >>> File: cypress/cyfmac43455-sdio.bin
> > >>> +Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin
> > >>> File: cypress/cyfmac43455-sdio.clm_blob
> > >>> +Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob
> > >>> File: cypress/cyfmac4354-sdio.bin
> > >>> +Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin
> > >>> File: cypress/cyfmac4354-sdio.clm_blob
> > >>> +Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob
> > >>> File: cypress/cyfmac4356-pcie.bin
> > >>> +Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin
> > >>> File: cypress/cyfmac4356-pcie.clm_blob
> > >>> +Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob
> > >>> File: cypress/cyfmac4356-sdio.bin
> > >>> +Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin
> > >>> File: cypress/cyfmac4356-sdio.clm_blob
> > >>> +Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob
> > >>> File: cypress/cyfmac43570-pcie.bin
> > >>> +Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin
> > >>> File: cypress/cyfmac43570-pcie.clm_blob
> > >>> +Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob
> > >>> File: cypress/cyfmac4373-sdio.bin
> > >>> +Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin
> > >>> File: cypress/cyfmac4373-sdio.clm_blob
> > >>> +Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob
> > >>> File: cypress/cyfmac54591-pcie.bin
> > >>> +Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin
> > >>> File: cypress/cyfmac54591-pcie.clm_blob
> > >>> +Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob
> > >>>
> > >>> Licence: Redistributable. See LICENCE.cypress for details.
> > >>>
> > >
> >
prev parent reply other threads:[~2021-01-08 0:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 16:04 [PATCH 2/2] cyprus: Link the new cyprus firmware to the old brcm files Peter Robinson
2021-01-05 16:04 ` [PATCH 1/2] brcm: remove old brcm firmwares that have newer cyprus variants Peter Robinson
2021-01-06 3:49 ` [PATCH 2/2] cyprus: Link the new cyprus firmware to the old brcm files Chi-Hsien Lin
2021-01-06 9:17 ` Peter Robinson
2021-01-06 9:19 ` Hans de Goede
2021-01-06 12:22 ` Josh Boyer
2021-01-08 0:52 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+5PVA78OgmYVw6mHgfyjRnSCh=qbzwQ+F-oeUM+aFHeJa5-bw@mail.gmail.com' \
--to=jwboyer@kernel.org \
--cc=Chi-Hsien.Lin@infineon.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=linux-firmware@kernel.org \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).