linux-firmware.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Pkshih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	 "linux-firmware@kernel.org" <linux-firmware@kernel.org>,
	 "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
Subject: Re: Request to update 8852a firmware of rtw89 to v0.13.8.0
Date: Thu, 13 May 2021 14:08:53 -0700	[thread overview]
Message-ID: <CA+ASDXMN__j0x5hN5t98C4k+upOcs+T1=MrivCbxRYa_-ENt_A@mail.gmail.com> (raw)
In-Reply-To: <876c29841fcf4d21ab2440cbb5879de2@realtek.com>

On Thu, May 13, 2021 at 2:38 AM Pkshih <pkshih@realtek.com> wrote:
> > -----Original Message-----
> > From: kvalo=codeaurora.org@mg.codeaurora.org [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
> > Behalf Of Kalle Valo

> > It can create confusion to the users if during review we make changes
> > how firmware files are handled. Some drivers have windows style .ini
> > files which are not ok in an upstream driver, there could be changes in
> > the file format etc.

Sure, good point. I figured if there's no driver merged anywhere
upstream, people (e.g., me) are taking their own life in their hands
trying to utilize arbitrary versions from the mailing list. But I
could see why you still don't want the potential mismatch.

> > But I have no strong opinion here, my main motivation is just to try to
> > keep things simple for maintaining the "interface" between
> > linux-firmware and kernel wireless drivers. My preference is that the
> > firmware files are ready for submission when a new driver is submitted
> > for review, but the firmware files are submitted only after the driver
> > is accepted.

Ack, that's definitely important to me. The first versions had no
publicly posted firmware, and at least one person (not me at the time)
asked for it. My extension of that is that I don't want to
_discourage_ vendors posting their firmware to public repos :)

> I think I can maintain the firmware in GitHub before driver is accepted,
> and add some information about firmware version and link in the cover of
> patchset. Then, people can take proper firmware.

Sure, that can work.

Thanks,
Brian

  reply	other threads:[~2021-05-13 21:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  8:59 Request to update 8852a firmware of rtw89 to v0.13.8.0 Pkshih
2021-05-03 13:17 ` Josh Boyer
2021-05-11 18:05 ` Kalle Valo
2021-05-11 18:05   ` Kalle Valo
2021-05-11 18:09   ` Josh Boyer
2021-05-11 19:10   ` Brian Norris
2021-05-11 19:10     ` Brian Norris
2021-05-13  6:09     ` Kalle Valo
2021-05-13  6:09       ` Kalle Valo
2021-05-13  9:38       ` Pkshih
2021-05-13 21:08         ` Brian Norris [this message]
2021-05-13 21:08           ` Brian Norris
2021-05-14  6:22           ` Kalle Valo
2021-05-14  6:22             ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ASDXMN__j0x5hN5t98C4k+upOcs+T1=MrivCbxRYa_-ENt_A@mail.gmail.com' \
    --to=briannorris@chromium.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-firmware@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).