Linux-Firmware Archive on lore.kernel.org
 help / color / Atom feed
From: Peter Robinson <pbrobinson@gmail.com>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: linux-firmware@kernel.org, Hans de Goede <hdegoede@redhat.com>,
	jwboyer@kernel.org
Subject: Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string
Date: Fri, 8 Jan 2021 23:35:15 +0000
Message-ID: <CALeDE9M4YZc9Wga5DvUebr4bgM8z3E-Aa7V-WoKxy01GfkaCSw@mail.gmail.com> (raw)
In-Reply-To: <20210108204916.1724298-1-jeremy.linton@arm.com>

On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> The rpi4 when booted with a full featured
> firmware reports a machine id from SMBIOS/DMI.
> Since that is used to select the firmware we
> need to add a new symlink.

Overall the patch is fine but the commit message is very opinionated
for a wifi firmware support patch. For one it's not a newer DMI string
for Raspberry Pi as all current strings are for device tree and in the
context of supporting WiFi the difference between what ever the
firmware you're referring to when you say "full featured firmware" is
irrelevant and marketing, does that "full featured firmware" support
more features of the wifi chipset than the other variants of firmware?

Except for the commit message:
Reviewed-by: Peter Robinson <pbrobinson@gmail.com>

> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>  WHENCE | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/WHENCE b/WHENCE
> index cbde48d..1f69078 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2711,6 +2711,7 @@ File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
>  Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
> +Link: brcm/brcmfmac43455-sdio.Raspberryi\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
>  File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
>  File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
>
> --
> 2.26.2
>

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 20:49 Jeremy Linton
2021-01-08 22:07 ` Hans de Goede
2021-01-08 23:18 ` Jeremy Linton
2021-01-08 23:35 ` Peter Robinson [this message]
2021-01-09 12:33   ` Josh Boyer
2021-01-09 13:09     ` Peter Robinson
2021-01-11  1:59       ` Jeremy Linton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALeDE9M4YZc9Wga5DvUebr4bgM8z3E-Aa7V-WoKxy01GfkaCSw@mail.gmail.com \
    --to=pbrobinson@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=jeremy.linton@arm.com \
    --cc=jwboyer@kernel.org \
    --cc=linux-firmware@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Firmware Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-firmware/0 linux-firmware/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-firmware linux-firmware/ https://lore.kernel.org/linux-firmware \
		linux-firmware@kernel.org
	public-inbox-index linux-firmware

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.lore.linux-firmware


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git