[PATCH] brcm: Link rpi4's wifi with newer DMI string

[PATCH] brcm: Link rpi4's wifi with newer DMI string

[Jeremy Linton]

The rpi4 when booted with a full featured
firmware reports a machine id from SMBIOS/DMI.
Since that is used to select the firmware we
need to add a new symlink.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 WHENCE | 1 +
 1 file changed, 1 insertion(+)

diff --git a/WHENCE b/WHENCE
index cbde48d..1f69078 100644
--- a/WHENCE
+++ b/WHENCE
@@ -2711,6 +2711,7 @@ File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
 File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
 Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
 File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
+Link: brcm/brcmfmac43455-sdio.Raspberryi\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
 File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
 File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
 
-- 
2.26.2

Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string

[Hans de Goede]

Hi,

On 1/8/21 9:49 PM, Jeremy Linton wrote:
> The rpi4 when booted with a full featured
> firmware reports a machine id from SMBIOS/DMI.
> Since that is used to select the firmware we
> need to add a new symlink.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
>  WHENCE | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/WHENCE b/WHENCE
> index cbde48d..1f69078 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2711,6 +2711,7 @@ File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
>  Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
> +Link: brcm/brcmfmac43455-sdio.Raspberryi\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
>  File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
>  File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
>  
> 

Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string

[Jeremy Linton]

Hi,

On 1/8/21 2:49 PM, Jeremy Linton wrote:
> The rpi4 when booted with a full featured
> firmware reports a machine id from SMBIOS/DMI.
> Since that is used to select the firmware we
> need to add a new symlink.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>   WHENCE | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/WHENCE b/WHENCE
> index cbde48d..1f69078 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2711,6 +2711,7 @@ File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
>   File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
>   Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
>   File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
> +Link: brcm/brcmfmac43455-sdio.Raspberryi\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt

Well looks like my turn to fail at using git/vi.

The "i" in "Raspberryi" above, which I fixed but didn't actually commit 
before sending this patch is wrong.

V2 on its way.


>   File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
>   File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
>   
> 

Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string

[Peter Robinson]

On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> The rpi4 when booted with a full featured
> firmware reports a machine id from SMBIOS/DMI.
> Since that is used to select the firmware we
> need to add a new symlink.

Overall the patch is fine but the commit message is very opinionated
for a wifi firmware support patch. For one it's not a newer DMI string
for Raspberry Pi as all current strings are for device tree and in the
context of supporting WiFi the difference between what ever the
firmware you're referring to when you say "full featured firmware" is
irrelevant and marketing, does that "full featured firmware" support
more features of the wifi chipset than the other variants of firmware?

Except for the commit message:
Reviewed-by: Peter Robinson <pbrobinson@gmail.com>

> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>  WHENCE | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/WHENCE b/WHENCE
> index cbde48d..1f69078 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2711,6 +2711,7 @@ File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
>  Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
>  File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
> +Link: brcm/brcmfmac43455-sdio.Raspberryi\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
>  File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
>  File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
>
> --
> 2.26.2
>

Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string

[Josh Boyer]

On Fri, Jan 8, 2021 at 6:35 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > The rpi4 when booted with a full featured
> > firmware reports a machine id from SMBIOS/DMI.
> > Since that is used to select the firmware we
> > need to add a new symlink.
>
> Overall the patch is fine but the commit message is very opinionated
> for a wifi firmware support patch. For one it's not a newer DMI string
> for Raspberry Pi as all current strings are for device tree and in the
> context of supporting WiFi the difference between what ever the
> firmware you're referring to when you say "full featured firmware" is
> irrelevant and marketing, does that "full featured firmware" support
> more features of the wifi chipset than the other variants of firmware?
>
> Except for the commit message:
> Reviewed-by: Peter Robinson <pbrobinson@gmail.com>

Not sure what I'm going to do with that.  Do you have a better commit
message you'd like to suggest, or are your objections not strong
enough to warrant a rewrite?

josh

> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> > ---
> >  WHENCE | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/WHENCE b/WHENCE
> > index cbde48d..1f69078 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -2711,6 +2711,7 @@ File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
> >  File: "brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt"
> >  Link: brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
> >  File: "brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt"
> > +Link: brcm/brcmfmac43455-sdio.Raspberryi\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> >  File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
> >  File: "brcm/brcmfmac4356-pcie.gpd-win-pocket.txt"
> >
> > --
> > 2.26.2
> >

Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string

[Peter Robinson]

On Sat, Jan 9, 2021 at 12:34 PM Josh Boyer <jwboyer@kernel.org> wrote:
>
> On Fri, Jan 8, 2021 at 6:35 PM Peter Robinson <pbrobinson@gmail.com> wrote:
> >
> > On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
> > >
> > > The rpi4 when booted with a full featured
> > > firmware reports a machine id from SMBIOS/DMI.
> > > Since that is used to select the firmware we
> > > need to add a new symlink.
> >
> > Overall the patch is fine but the commit message is very opinionated
> > for a wifi firmware support patch. For one it's not a newer DMI string
> > for Raspberry Pi as all current strings are for device tree and in the
> > context of supporting WiFi the difference between what ever the
> > firmware you're referring to when you say "full featured firmware" is
> > irrelevant and marketing, does that "full featured firmware" support
> > more features of the wifi chipset than the other variants of firmware?
> >
> > Except for the commit message:
> > Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
>
> Not sure what I'm going to do with that.  Do you have a better commit
> message you'd like to suggest, or are your objections not strong
> enough to warrant a rewrite?

How about:
brcm: Add link for Raspberry Pi 4 for matching DMI string

When the Raspberry Pi 4 is booted using a ACPI firmware
the wireless driver matches against a DMI string so
add a link to ensure the wireless works with that firmware
variant as well.

Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string

[Jeremy Linton]

Hi,

On 1/9/21 7:09 AM, Peter Robinson wrote:
> On Sat, Jan 9, 2021 at 12:34 PM Josh Boyer <jwboyer@kernel.org> wrote:
>>
>> On Fri, Jan 8, 2021 at 6:35 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>>>
>>> On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
>>>>
>>>> The rpi4 when booted with a full featured
>>>> firmware reports a machine id from SMBIOS/DMI.
>>>> Since that is used to select the firmware we
>>>> need to add a new symlink.
>>>
>>> Overall the patch is fine but the commit message is very opinionated
>>> for a wifi firmware support patch. For one it's not a newer DMI string
>>> for Raspberry Pi as all current strings are for device tree and in the
>>> context of supporting WiFi the difference between what ever the
>>> firmware you're referring to when you say "full featured firmware" is
>>> irrelevant and marketing, does that "full featured firmware" support
>>> more features of the wifi chipset than the other variants of firmware?
>>>
>>> Except for the commit message:
>>> Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
>>
>> Not sure what I'm going to do with that.  Do you have a better commit
>> message you'd like to suggest, or are your objections not strong
>> enough to warrant a rewrite?
> 
> How about:
> brcm: Add link for Raspberry Pi 4 for matching DMI string
> 
> When the Raspberry Pi 4 is booted using a ACPI firmware
> the wireless driver matches against a DMI string so
> add a link to ensure the wireless works with that firmware
> variant as well.
> 

I will come up with something and re-post it tomorrow, although I think 
Peter needs to read it with a more euphemistic tone... :)