Re: pull request: iwlwifi firmware updates 2021-03-05-v2

From: Thomas Backlund <tmb@tmb.nu>
To: Luca Coelho <luca@coelho.fi>,
	"linux-firmware@kernel.org" <linux-firmware@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"kyle@infradead.org" <kyle@infradead.org>,
	"jwboyer@kernel.org" <jwboyer@kernel.org>,
	"ben@decadent.org.uk" <ben@decadent.org.uk>,
	golan.ben.ami@intel.com
Subject: Re: pull request: iwlwifi firmware updates 2021-03-05-v2
Date: Wed, 10 Mar 2021 09:46:47 +0000	[thread overview]
Message-ID: <dc668115-049c-0bbc-b25e-917ccf1bbdee@tmb.nu> (raw)
In-Reply-To: <42eb781e8f89b92ff54a4d65b0916d420eb2a381.camel@coelho.fi>

Den 10.3.2021 kl. 11:26, skrev Luca Coelho:
> Your email was in HTML, so it probably didn't reach the list.

Oops. sorry about that...

seems thunderbird decides on its own sometimes to swich it around...
evern if I have default to text...

> On Wed, 2021-03-10 at 09:09 +0000, Thomas Backlund wrote:
>> More  "issues"...
>>
>> Den 9.3.2021 kl. 13:57, skrev Luca Coelho:
>> Hi,
>>
>> This is v2 of my update which contains some new and updated files for
>> all our currently maintained FW binaries.
>>
>> In v2:
>>
>>     * Fixed WHENCE so that the new files match, with "62" instead of
>>     "59".
>>
>> Please pull or let me know if there are any issues.
>>
>> --
>> Cheers,
>> Luca.
>>
>>
>> The following changes since commit
>> 5ecd13ffe8e24385cf4f30f3d0dcaff4dfb24de2:
>>
>>    Mellanox: Add new mlxsw_spectrum firmware xx.2008.2406 (2021-03-03
>> 13:23:49 -0500)
>>
>> are available in the Git repository at:
>>
>>    git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-
>> firmware.git iwlwifi-fw-2021-03-05-v2
>>
>> for you to fetch changes up to
>> b46d336044c448987589bd6cf3057f404c5581ad:
>>
>>    iwlwifi: add new FWs from core59-66 release (2021-03-09 13:51:26
>> +0200)
>>
>> ----------------------------------------------------------------
>> Update iwlwifi firmwares to Core59-66
>>
>> ----------------------------------------------------------------
>> Luca Coelho (3):
>>        iwlwifi: update 7265D firmware
>>
>> This one looks old... stuck in limbo for over 1.5 years... is that
>> correct ?
>> author    Luca Coelho <luciano.coelho@intel.com>    2019-08-23
>> 07:35:14 +0300
>>   committer    Luca Coelho <luciano.coelho@intel.com>    2021-03-05
>> 11:37:56 +0200
> Oh, I just reused the commit message from before and edited it as
> needed.  Does it really matter?

I guess not..

it was more a "is it acctually a correct commit " as it looked weird
when being so old...

considering the last update to the same firmware happend on 2020-10-14

>>        iwlwifi: update 9000-family firmwares
>>
>> This one adds duplicated fileinfo in WHENCE
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware.git/commit/?id=a6720504c812c1e8b0979a81d15b6ce6b4d87ae7
>> instead of updating existing ones.
> Okay, I'll fix it.
>
>>        iwlwifi: add new FWs from core59-66 release
>>
>> This one still adds some duplicated WHENCE stuff for  *-59.ucode:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware.git/commit/?id=b46d336044c448987589bd6cf3057f404c5581ad
>>
>> +File: iwlwifi-cc-a0-59.ucode
>> +Version: 59.49eeb572.0
>> +
>> +File: iwlwifi-Qu-b0-hr-b0-59.ucode
>> +Version: 59.49eeb572.0
> Yep, copy/paste issue again, I'll fix it.
>
> --
> Luca.

--

Thomas