Linux-Firmware Archive on lore.kernel.org
 help / color / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Josh Boyer <jwboyer@kernel.org>
Cc: Linux Firmware <linux-firmware@kernel.org>
Subject: Re: [PATCH] Add symlink for Dell XPS 15 9550 Broadcom Bluetooth patch-ram file
Date: Tue, 21 Apr 2020 09:46:31 +0200
Message-ID: <df06edbf-003b-bb1c-ac8e-d46a3c5ed2da@redhat.com> (raw)
In-Reply-To: <CA+5PVA5dD7LWLfh4HaQnzZOLKi-eWJjX9qBJmEsKqRhJ2HD-UQ@mail.gmail.com>

Hi,

On 4/21/20 12:31 AM, Josh Boyer wrote:
> On Fri, Apr 17, 2020 at 12:20 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> The linux-firmware repo does not contain many Broadcom (now Cypress)
>> Bluetooth patch-ram files, because we have never been able to get
>> permission to re-distribute those.
>>
>> We do have one file for the for HTC Vive, which was submitted by HTC
>> themselves with permission from Cypress.
>>
>> That file contain a "BCM20703A1 Generic USB 20Mhz fcbga_BU" patch-ram
>> build. The patch-ram files used by Windows for the Bluetooth module
>> in the XPS 15 9550, USB-id 0a5c:6410 is also a "BCM20703A1 Generic
>> USB 20Mhz fcbga_BU" patch-ram build. Since the build-parameters
>> (crystal MHz, package/module type used) between the 2 builds are an
>> exact match we can also use the HTC submitted patch-ram for the
>> XPS 15 9550. So lets add a symlink for this.
>>
>> This will make the Bluetooth on the XPS 15 9550 work out of the box,
>> when linux-firmware is installed, without the user needing to go and
>> find a suitable patch-ram file themselves.
>>
>> This has been tested on a XPS 15 9550 with both Bluetooth HID and
>> Bluetooth audio devices.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   WHENCE                 | 1 +
>>   brcm/BCM-0a5c-6410.hcd | 1 +
>>   2 files changed, 2 insertions(+)
>>   create mode 120000 brcm/BCM-0a5c-6410.hcd
> 
> It should be possible to do this by simply using the Link directive in
> the WHENCE file.  That will create the symlink at installation time.
> It's a fairly recent enhancement.  I'll look at it tomorrow and adjust
> if so.

Nice, that would indeed be an improvement as in the past make install
turned the symlinks into file copies IIRC.

Perhaps you can also convert the brcm/brcmfmac43362-sdio.lemaker,bananapro.txt
symlink to use this new method?

Thank you for taking care of adjusting the patch.

Regards,

Hans


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 16:20 Hans de Goede
2020-04-20 22:31 ` Josh Boyer
2020-04-21  7:46   ` Hans de Goede [this message]
2020-04-21 11:47     ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df06edbf-003b-bb1c-ac8e-d46a3c5ed2da@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=jwboyer@kernel.org \
    --cc=linux-firmware@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Firmware Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-firmware/0 linux-firmware/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-firmware linux-firmware/ https://lore.kernel.org/linux-firmware \
		linux-firmware@kernel.org
	public-inbox-index linux-firmware

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.lore.linux-firmware


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git