From: Tom Rix <trix@redhat.com>
To: Moritz Fischer <mdf@kernel.org>,
Russ Weight <russell.h.weight@intel.com>
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fpga: add cancel() and get_error() to update ops
Date: Thu, 20 May 2021 06:39:09 -0700 [thread overview]
Message-ID: <053373e3-bf53-d662-d4a2-1297efed830d@redhat.com> (raw)
In-Reply-To: <YKV6G+9FOgMsqQuz@epycbox.lan>
On 5/19/21 1:50 PM, Moritz Fischer wrote:
> Tom,
>
> On Wed, May 19, 2021 at 01:43:18PM -0700, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A user may want to cancel an update or get
>> more information on when an update fails.
>> Add some device ops to do these.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> include/linux/fpga/fpga-mgr.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
>> index ab68280f3b4a4..31d6ebc34d87a 100644
>> --- a/include/linux/fpga/fpga-mgr.h
>> +++ b/include/linux/fpga/fpga-mgr.h
>> @@ -111,6 +111,8 @@ struct fpga_image_info {
>> * @write: write count bytes of configuration data to the FPGA
>> * @write_sg: write the scatter list of configuration data to the FPGA
>> * @write_complete: set FPGA to operating state after writing is done
>> + * @cancel: cancel the update
>> + * @get_error: get extended error information
>> */
>> struct fpga_manager_update_ops {
>> int (*write_init)(struct fpga_manager *mgr,
>> @@ -120,6 +122,8 @@ struct fpga_manager_update_ops {
>> int (*write_sg)(struct fpga_manager *mgr, struct sg_table *sgt);
>> int (*write_complete)(struct fpga_manager *mgr,
>> struct fpga_image_info *info);
>> + int (*cancel)(struct fpga_manager *mgr);
>> + int (*get_error)(struct fpga_manager *mgr, u64 *err);
>> };
>>
>> /**
>> --
>> 2.26.3
>>
> There is no user for this, so if we add this, we add it with code
> calling it.
These additions come for unioning the fpga manager ops with the secure
manager ops.
So will be needed if the secure manager goes this this way.
Tom
> Thanks
>
> - Moritz
>
prev parent reply other threads:[~2021-05-20 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 20:43 [PATCH 2/2] fpga: add cancel() and get_error() to update ops trix
2021-05-19 20:50 ` Moritz Fischer
2021-05-20 13:39 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=053373e3-bf53-d662-d4a2-1297efed830d@redhat.com \
--to=trix@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).