linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nava kishore Manne <nava.kishore.manne@amd.com>,
	git@amd.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com,
	mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com,
	trix@redhat.com, p.zabel@pengutronix.de,
	gregkh@linuxfoundation.org, ronak.jain@xilinx.com,
	rajan.vaja@xilinx.com, abhyuday.godhasara@xilinx.com,
	piyush.mehta@xilinx.com, lakshmi.sai.krishna.potthuri@xilinx.com,
	harsha.harsha@xilinx.com, linus.walleij@linaro.org,
	nava.manne@xilinx.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: Re: [PATCH 3/4] bindings: firmware: Update binding doc for the zynqmp afi config node
Date: Wed, 24 Aug 2022 15:57:37 +0300	[thread overview]
Message-ID: <09308102-f927-125e-4321-d231decbd6c9@linaro.org> (raw)
In-Reply-To: <20220824035542.706433-4-nava.kishore.manne@amd.com>

Use subject prefixes matching the subsystem (git log --oneline -- ...).

"bindings" is no correct.

On 24/08/2022 06:55, Nava kishore Manne wrote:
> Updates binding document for the zynqmp afi config node to handle the
> PS_PL Bus-width and resets.

Use imperative language:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> ---
>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml     | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index f14f7b454f07..9504665cad95 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -59,6 +59,13 @@ properties:
>        controller.
>      type: object
>  
> +  zynqmp-fpga:

Just: fpga

> +    $ref: /schemas/fpga/xlnx,zynqmp-afi-fpga.yaml#
> +    description: The Zynq UltraScale+ MPSoC Processing System core provides
> +      access from PL masters to PS internal peripherals, and memory through
> +      AXI FIFO interface(AFI)
> +    type: object
> +
>  required:
>    - compatible
>  


Best regards,
Krzysztof

  reply	other threads:[~2022-08-24 12:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24  3:55 [PATCH 0/4]Add afi config drivers support Nava kishore Manne
2022-08-24  3:55 ` [PATCH 1/4] firmware: xilinx: Add afi ioctl support Nava kishore Manne
2022-08-27  6:21   ` Xu Yilun
2022-08-30  9:25     ` Manne, Nava kishore
2022-09-03 17:13       ` Xu Yilun
2022-08-24  3:55 ` [PATCH 2/4] bindings: fpga: Add binding doc for the zynqmp afi config driver Nava kishore Manne
2022-08-24 12:58   ` Krzysztof Kozlowski
2022-08-30  5:31     ` Manne, Nava kishore
2022-08-30 18:27       ` Rob Herring
2022-08-30 18:25   ` Rob Herring
2022-08-24  3:55 ` [PATCH 3/4] bindings: firmware: Update binding doc for the zynqmp afi config node Nava kishore Manne
2022-08-24 12:57   ` Krzysztof Kozlowski [this message]
2022-08-30  5:41     ` Manne, Nava kishore
2022-08-24  3:55 ` [PATCH 4/4] fpga: zynqmp: Add afi config driver Nava kishore Manne
2022-08-24 12:59   ` Krzysztof Kozlowski
2022-08-27 12:26   ` Xu Yilun
2022-08-30  9:19     ` Manne, Nava kishore
2022-09-01  9:53       ` Marco Pagani
2022-09-03 17:44         ` Xu Yilun
2022-09-12 20:02           ` Marco Pagani
2022-09-03 17:33       ` Xu Yilun
2022-08-27  6:02 ` [PATCH 0/4]Add afi config drivers support Xu Yilun
2022-08-30  6:05   ` Manne, Nava kishore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09308102-f927-125e-4321-d231decbd6c9@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=abhyuday.godhasara@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hao.wu@intel.com \
    --cc=harsha.harsha@xilinx.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=nava.kishore.manne@amd.com \
    --cc=nava.manne@xilinx.com \
    --cc=p.zabel@pengutronix.de \
    --cc=piyush.mehta@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=ronak.jain@xilinx.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).