From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C1EC4320A for ; Mon, 2 Aug 2021 11:47:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9499C60FC4 for ; Mon, 2 Aug 2021 11:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbhHBLrM (ORCPT ); Mon, 2 Aug 2021 07:47:12 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40816 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233341AbhHBLrL (ORCPT ); Mon, 2 Aug 2021 07:47:11 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 172BYQLU020153; Mon, 2 Aug 2021 07:46:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=u+Y6F5QtBSt4VUckLV0sPWwGGN6ZjKtKBgxX2XNTfig=; b=aSJ3jH42W5k2fcz4VyHSJiozCmgoAVVfnTyTpehvQ9q9u5rGk35j41crgeupZZfQABC8 g1FPETQIS/VOHGzo89u9HyFJZWOqHLZaLkLOk2MfKPljlH+Kv+QXoVC+OExS5/1tjhvN Cyi65WBzZAicyXbxRMBHF6vCxG64Qrc7gsqmrC6MmeEWRgpILcmS7H6SFxH9yf6OljIo F5Dv2Un9OjuAsvtLkvWusrYOx4E7hpge0nH7OfswJaJDXK0GJsQBINoEsFywMIIDrFZb QQwqNe4hBD1ixeJ+MZWAPsyg3mzWaH3AJNFnzmfBbNZT0dZ0zmmPG8ZbNTAy23Y/diiI HQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a5ke59mba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Aug 2021 07:46:53 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 172BZqjF025050; Mon, 2 Aug 2021 07:46:53 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a5ke59may-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Aug 2021 07:46:53 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 172BkaTP027039; Mon, 2 Aug 2021 11:46:52 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma04dal.us.ibm.com with ESMTP id 3a4x5aww6k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Aug 2021 11:46:52 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 172Bkp1C52560244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 2 Aug 2021 11:46:51 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A9A9124075; Mon, 2 Aug 2021 11:46:51 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 08EC6124052; Mon, 2 Aug 2021 11:46:46 +0000 (GMT) Received: from localhost.localdomain (unknown [9.199.34.7]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 2 Aug 2021 11:46:45 +0000 (GMT) Subject: Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting To: Moritz Fischer Cc: will@kernel.org, hao.wu@intel.com, mark.rutland@arm.com, trix@redhat.com, yilun.xu@intel.com, linux-fpga@vger.kernel.org, maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, rnsastry@linux.ibm.com, linux-perf-users@vger.kernel.org, stable@vger.kernel.org References: <20210713074216.208391-1-kjain@linux.ibm.com> <61495dc0-f496-992c-1d2a-9229a04e6e44@linux.ibm.com> From: kajoljain Message-ID: <0d31afc5-b86e-4da6-878c-be4ba7b4a23a@linux.ibm.com> Date: Mon, 2 Aug 2021 17:16:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1Gca7qDh268Hhxr5iv5qsOpjYdAOm4rx X-Proofpoint-ORIG-GUID: 1UMGX8qImnvnJCp0cj0jdn-uhbyA4gR0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-02_05:2021-08-02,2021-08-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108020077 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 8/2/21 2:28 PM, Moritz Fischer wrote: > On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote: >> >> >> On 7/13/21 1:12 PM, Kajol Jain wrote: >>> The performance reporting driver added cpu hotplug >>> feature but it didn't add pmu migration call in cpu >>> offline function. >>> This can create an issue incase the current designated >>> cpu being used to collect fme pmu data got offline, >>> as based on current code we are not migrating fme pmu to >>> new target cpu. Because of that perf will still try to >>> fetch data from that offline cpu and hence we will not >>> get counter data. >>> >>> Patch fixed this issue by adding pmu_migrate_context call >>> in fme_perf_offline_cpu function. >>> >>> Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support") >>> Tested-by: Xu Yilun >>> Acked-by: Wu Hao >>> Signed-off-by: Kajol Jain >>> Cc: stable@vger.kernel.org >>> --- >> >> Any update on this patch? Please let me know if any changes required. >> >> Thanks, >> Kajol Jain > > It's in my 'fixes' branch. Thanks Moritz for informing me. Thanks, Kajol Jain > > - Moritz >