From: "Martin Hundebøll" <mhu@silicom.dk>
To: trix@redhat.com, mdf@kernel.org, hao.wu@intel.com,
michal.simek@xilinx.com
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/4] fpga: add FPGA_MGR_REIMAGE flag
Date: Mon, 28 Jun 2021 09:35:38 +0200 [thread overview]
Message-ID: <17e69761-9922-b3f2-5bd7-e29190f0b72c@silicom.dk> (raw)
In-Reply-To: <20210625195849.837976-4-trix@redhat.com>
On 25/06/2021 21.58, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> If this flag is set the reimage ops will be used otherwise the
> reconfig ops will be used to write the image
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> include/linux/fpga/fpga-mgr.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
> index 53f9402d6aa17..0791e22b07f88 100644
> --- a/include/linux/fpga/fpga-mgr.h
> +++ b/include/linux/fpga/fpga-mgr.h
> @@ -67,12 +67,15 @@ enum fpga_mgr_states {
> * %FPGA_MGR_BITSTREAM_LSB_FIRST: SPI bitstream bit order is LSB first
> *
> * %FPGA_MGR_COMPRESSED_BITSTREAM: FPGA bitstream is compressed
> + *
> + * %FPGA_MGR_REIMAGE: Reimage the whole card, fpga bs and other device fw
> */
> #define FPGA_MGR_PARTIAL_RECONFIG BIT(0)
> #define FPGA_MGR_EXTERNAL_CONFIG BIT(1)
> #define FPGA_MGR_ENCRYPTED_BITSTREAM BIT(2)
> #define FPGA_MGR_BITSTREAM_LSB_FIRST BIT(3)
> #define FPGA_MGR_COMPRESSED_BITSTREAM BIT(4)
> +#define FPGA_MGR_REIMAGE BIT(5)
Are you mixing spaces with tabs here?
// Martin
next prev parent reply other threads:[~2021-06-28 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 19:58 [PATCH v5 0/4] generalize fpga_mgr_load trix
2021-06-25 19:58 ` [PATCH v5 1/4] fpga: generalize updating the card trix
2021-06-28 18:44 ` Moritz Fischer
2021-06-28 20:55 ` Tom Rix
2021-06-25 19:58 ` [PATCH v5 2/4] fpga: add FPGA_MGR_REIMAGE flag trix
2021-06-28 7:35 ` Martin Hundebøll [this message]
2021-06-25 19:58 ` [PATCH v5 3/4] fpga: pass fpga_manager_update_ops to the fpga_manager_write functions trix
2021-06-28 7:42 ` Martin Hundebøll
2021-06-25 19:58 ` [PATCH v5 4/4] fpga: use reimage ops in fpga_mgr_load() trix
2021-06-28 7:03 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e69761-9922-b3f2-5bd7-e29190f0b72c@silicom.dk \
--to=mhu@silicom.dk \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).