From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: trix@redhat.com Subject: [PATCH v2 2/2] fpga: Fix dead store in fpga-bridge.c Date: Mon, 8 Jun 2020 05:54:46 -0700 Message-Id: <20200608125446.23311-3-trix@redhat.com> In-Reply-To: <20200608125446.23311-1-trix@redhat.com> References: <20200608125446.23311-1-trix@redhat.com> Content-Type: text/plain; charset=US-ASCII To: mdf@kernel.org Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix List-ID: From: Tom Rix Using clang's scan-build/view this issue was flagged a dead store issue in fpga-bridge.c warning: Value stored to 'ret' is never read [deadcode.DeadStores] ret = id; Signed-off-by: Tom Rix --- drivers/fpga/fpga-bridge.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c index 4bab9028940a..2deccacc3aa7 100644 --- a/drivers/fpga/fpga-bridge.c +++ b/drivers/fpga/fpga-bridge.c @@ -328,7 +328,7 @@ struct fpga_bridge *fpga_bridge_create(struct device *dev, const char *name, void *priv) { struct fpga_bridge *bridge; - int id, ret = 0; + int id, ret; if (!name || !strlen(name)) { dev_err(dev, "Attempt to register with no name!\n"); @@ -340,10 +340,8 @@ struct fpga_bridge *fpga_bridge_create(struct device *dev, const char *name, return NULL; id = ida_simple_get(&fpga_bridge_ida, 0, 0, GFP_KERNEL); - if (id < 0) { - ret = id; + if (id < 0) goto error_kfree; - } mutex_init(&bridge->mutex); INIT_LIST_HEAD(&bridge->node); -- 2.18.2