From: Moritz Fischer <mdf@kernel.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-fpga@vger.kernel.org, Moritz Fischer <mdf@kernel.org>,
Tom Rix <trix@redhat.com>, Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH v4 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings
Date: Sun, 30 Aug 2020 17:05:27 -0700 [thread overview]
Message-ID: <20200831000527.GB7421@epycbox.lan> (raw)
In-Reply-To: <20200830163850.8380-2-luca@lucaceresoli.net>
On Sun, Aug 30, 2020 at 06:38:47PM +0200, Luca Ceresoli wrote:
> Most dev_err messages in this file have no final dot. Remove the only two
> exceptions to make them consistent.
>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>
> ---
>
> Changes in v4:
> - add Reviewed-by Tom Rix
>
> Changes in v3: none.
>
> Changes in v2:
> - move before the "provide better diagnostics on programming failure"
> patch for clarity
> ---
> drivers/fpga/xilinx-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c
> index 502fae0d1d85..01f494172379 100644
> --- a/drivers/fpga/xilinx-spi.c
> +++ b/drivers/fpga/xilinx-spi.c
> @@ -77,7 +77,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
> int err;
>
> if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) {
> - dev_err(&mgr->dev, "Partial reconfiguration not supported.\n");
> + dev_err(&mgr->dev, "Partial reconfiguration not supported\n");
> return -EINVAL;
> }
>
> @@ -169,7 +169,7 @@ static int xilinx_spi_write_complete(struct fpga_manager *mgr,
> return xilinx_spi_apply_cclk_cycles(conf);
> }
>
> - dev_err(&mgr->dev, "Timeout after config data transfer.\n");
> + dev_err(&mgr->dev, "Timeout after config data transfer\n");
> return -ETIMEDOUT;
> }
>
> --
> 2.28.0
>
Applied to for-next,
Thanks
next prev parent reply other threads:[~2020-08-31 0:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 16:38 [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Luca Ceresoli
2020-08-30 16:38 ` [PATCH v4 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings Luca Ceresoli
2020-08-31 0:05 ` Moritz Fischer [this message]
2020-08-30 16:38 ` [PATCH v4 3/5] fpga manager: xilinx-spi: fix write_complete timeout handling Luca Ceresoli
2020-08-31 0:07 ` Moritz Fischer
2020-08-30 16:38 ` [PATCH v4 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value() Luca Ceresoli
2020-08-31 0:09 ` Moritz Fischer
2020-08-30 16:38 ` [PATCH v4 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure Luca Ceresoli
2020-08-31 0:09 ` Moritz Fischer
2020-08-31 0:05 ` [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831000527.GB7421@epycbox.lan \
--to=mdf@kernel.org \
--cc=agust@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).