From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C75E3C433E2 for ; Tue, 15 Sep 2020 05:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E48720897 for ; Tue, 15 Sep 2020 05:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726057AbgIOFYC (ORCPT ); Tue, 15 Sep 2020 01:24:02 -0400 Received: from mga05.intel.com ([192.55.52.43]:9052 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgIOFYB (ORCPT ); Tue, 15 Sep 2020 01:24:01 -0400 IronPort-SDR: 5fDPHJgc6/nEFfTmuzOIW4xt2JhKPlkOZ5y9DBDDe3uXpb/HIrMtVOEh43V0pPgJES4eve9zKu JZ/75CBj69pA== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="244034476" X-IronPort-AV: E=Sophos;i="5.76,428,1592895600"; d="scan'208";a="244034476" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 22:23:58 -0700 IronPort-SDR: u6gi3wPJ1Gc8j2ISZDQLErhIL1K48EjVlDFiwVY+ViO+p3ZUpHkMc7ZRhG4PTLAAGJyknB+da+ BrxWUxWS/7PQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,428,1592895600"; d="scan'208";a="482621835" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.141]) by orsmga005.jf.intel.com with ESMTP; 14 Sep 2020 22:23:55 -0700 Date: Tue, 15 Sep 2020 13:19:33 +0800 From: Xu Yilun To: "Wu, Hao" Cc: Moritz Fischer , "linux-fpga@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "masahiroy@kernel.org" , "trix@redhat.com" , "lgoncalv@redhat.com" , Matthew Gerlach , "Weight, Russell H" Subject: Re: [PATCH v2 2/4] dfl: add dfl bus support to MODULE_DEVICE_TABLE() Message-ID: <20200915051933.GA13516@yilunxu-OptiPlex-7050> References: <1600140473-12351-1-git-send-email-yilun.xu@intel.com> <1600140473-12351-3-git-send-email-yilun.xu@intel.com> <20200915035927.GB2217@epycbox.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-fpga-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Tue, Sep 15, 2020 at 12:08:38PM +0800, Wu, Hao wrote: > > On Tue, Sep 15, 2020 at 11:27:51AM +0800, Xu Yilun wrote: > > > Device Feature List (DFL) is a linked list of feature headers within the > > > device MMIO space. It is used by FPGA to enumerate multiple sub features > > > within it. Each feature can be uniquely identified by DFL type and > > > feature id, which can be read out from feature headers. > > > > > > A dfl bus helps DFL framework modularize DFL device drivers for different > > > sub features. The dfl bus matches its devices and drivers by DFL type and > > > feature id. > > > > > > This patch add dfl bus support to MODULE_DEVICE_TABLE() by adding info > > > about struct dfl_device_id in devicetable-offsets.c and add a dfl entry > > > point in file2alias.c. > > > > > > Signed-off-by: Xu Yilun > > > Signed-off-by: Wu Hao > > > Signed-off-by: Matthew Gerlach > > > Signed-off-by: Russ Weight > > > Acked-by: Wu Hao > > Yilun, > > I haven't acked-by this patch as it doesn't modify any dfl files, ideally you Sorry, I misunderstood your comments "Acked-by: xxx for DFL related changes after this fix". > need acked-by from real maintainer of scripts/mod code, right? Ideally yes. From the MAINTAINERS it is Masahiro Yamada, I added him on the "to" list. But I see some other patches (also for devtable entries) in kernel don't have his acked-by. Hi Moritz: Do you have any ideas on that? Thanks, Yilun. > > Thanks > Hao > > > > --- > > > v2: add comments for the format of modalias > > > --- > > > scripts/mod/devicetable-offsets.c | 4 ++++ > > > scripts/mod/file2alias.c | 17 +++++++++++++++++ > > > 2 files changed, 21 insertions(+) > > > > > > diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable- > > offsets.c > > > index 27007c1..d8350ee 100644 > > > --- a/scripts/mod/devicetable-offsets.c > > > +++ b/scripts/mod/devicetable-offsets.c > > > @@ -243,5 +243,9 @@ int main(void) > > > DEVID(mhi_device_id); > > > DEVID_FIELD(mhi_device_id, chan); > > > > > > +DEVID(dfl_device_id); > > > +DEVID_FIELD(dfl_device_id, type); > > > +DEVID_FIELD(dfl_device_id, feature_id); > > > + > > > return 0; > > > } > > > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c > > > index 2417dd1..9fd2e60 100644 > > > --- a/scripts/mod/file2alias.c > > > +++ b/scripts/mod/file2alias.c > > > @@ -1368,6 +1368,22 @@ static int do_mhi_entry(const char *filename, > > void *symval, char *alias) > > > return 1; > > > } > > > > > > +/* Looks like: dfl:tNfN */ > > > +static int do_dfl_entry(const char *filename, void *symval, char *alias) > > > +{ > > > +DEF_FIELD(symval, dfl_device_id, type); > > > +DEF_FIELD(symval, dfl_device_id, feature_id); > > > + > > > +/* > > > + * type contains 4 valid bits and feature_id contains 12 valid bits > > > + * according to DFL specification. > > > + */ > > > +sprintf(alias, "dfl:t%01Xf%03X", type, feature_id); > > > + > > > +add_wildcard(alias); > > > +return 1; > > > +} > > > + > > > /* Does namelen bytes of name exactly match the symbol? */ > > > static bool sym_is(const char *name, unsigned namelen, const char > > *symbol) > > > { > > > @@ -1442,6 +1458,7 @@ static const struct devtable devtable[] = { > > > {"tee", SIZE_tee_client_device_id, do_tee_entry}, > > > {"wmi", SIZE_wmi_device_id, do_wmi_entry}, > > > {"mhi", SIZE_mhi_device_id, do_mhi_entry}, > > > +{"dfl", SIZE_dfl_device_id, do_dfl_entry}, > > > }; > > > > > > /* Create MODULE_ALIAS() statements. > > > -- > > > 2.7.4 > > > > > Applied to for-next, > > > > Thanks