linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: mdf@kernel.org, krzk@kernel.org, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, trix@redhat.com,
	lgoncalv@redhat.com, hao.wu@intel.com,
	Matthew Gerlach <matthew.gerlach@linux.intel.com>,
	Russ Weight <russell.h.weight@intel.com>
Subject: Re: [PATCH v9 2/6] fpga: dfl: move dfl_device_id to mod_devicetable.h
Date: Sun, 11 Oct 2020 16:43:51 +0200	[thread overview]
Message-ID: <20201011144351.GA271501@kroah.com> (raw)
In-Reply-To: <1602313793-21421-3-git-send-email-yilun.xu@intel.com>

On Sat, Oct 10, 2020 at 03:09:49PM +0800, Xu Yilun wrote:
> In order to support MODULE_DEVICE_TABLE() for dfl device driver, this
> patch moves struct dfl_device_id to mod_devicetable.h
> 
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Acked-by: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> v2: fix the order for the header file
> v3: rebase the patch for dfl bus name change
> v9: rebase the patch for dfl bus name changes back to "dfl"
> ---
>  drivers/fpga/dfl.h              | 13 +------------
>  include/linux/mod_devicetable.h | 12 ++++++++++++
>  2 files changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index ac373b1..549c790 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -22,6 +22,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/iopoll.h>
>  #include <linux/io-64-nonatomic-lo-hi.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/uuid.h>
> @@ -526,18 +527,6 @@ enum dfl_id_type {
>  };
>  
>  /**
> - * struct dfl_device_id -  dfl device identifier
> - * @type: DFL FIU type of the device. See enum dfl_id_type.
> - * @feature_id: feature identifier local to its DFL FIU type.
> - * @driver_data: driver specific data.
> - */
> -struct dfl_device_id {
> -	u16 type;
> -	u16 feature_id;
> -	unsigned long driver_data;
> -};
> -
> -/**
>   * struct dfl_device - represent an dfl device on dfl bus
>   *
>   * @dev: generic device interface.
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> index 5b08a47..66e1405 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -838,4 +838,16 @@ struct mhi_device_id {
>  	kernel_ulong_t driver_data;
>  };
>  
> +/**
> + * struct dfl_device_id -  dfl device identifier

I still have no idea what "dfl" means.  Please at the very least,
explain it here.

thanks,

greg k-h

  reply	other threads:[~2020-10-11 14:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10  7:09 [PATCH v9 0/6] add DFL bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-10-10  7:09 ` [PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices Xu Yilun
2020-10-10 15:07   ` Tom Rix
2020-10-12  2:41     ` Xu Yilun
2020-10-12 14:07       ` Tom Rix
2020-10-12 14:32         ` Greg KH
2020-10-10  7:09 ` [PATCH v9 2/6] fpga: dfl: move dfl_device_id to mod_devicetable.h Xu Yilun
2020-10-11 14:43   ` Greg KH [this message]
2020-10-12  2:27     ` Xu Yilun
2020-10-10  7:09 ` [PATCH v9 3/6] fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-10-10  7:09 ` [PATCH v9 4/6] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h Xu Yilun
2020-10-11 14:45   ` Greg KH
2020-10-12  2:31     ` Xu Yilun
2020-10-10  7:09 ` [PATCH v9 5/6] fpga: dfl: add support for N3000 Nios private feature Xu Yilun
2020-10-10 21:21   ` Tom Rix
2020-10-12  6:51     ` Xu Yilun
2020-10-12 14:19       ` Tom Rix
2020-10-10  7:09 ` [PATCH v9 6/6] memory: dfl-emif: add the DFL EMIF private feature driver Xu Yilun
2020-10-12 16:40   ` Krzysztof Kozlowski
2020-10-12 16:58     ` Moritz Fischer
2020-10-12 17:27       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201011144351.GA271501@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hao.wu@intel.com \
    --cc=krzk@kernel.org \
    --cc=lgoncalv@redhat.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=mdf@kernel.org \
    --cc=russell.h.weight@intel.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).