From: Moritz Fischer <mdf@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
trix@redhat.com, Moritz Fischer <mdf@kernel.org>
Subject: [RESEND PATCH 09/10] fpga: fpga-mgr: zynqmp: Simplify registration
Date: Sun, 15 Nov 2020 11:51:26 -0800 [thread overview]
Message-ID: <20201115195127.284487-10-mdf@kernel.org> (raw)
In-Reply-To: <20201115195127.284487-1-mdf@kernel.org>
Simplify registration using new devm_fpga_mgr_register() API.
Reviewed-by: Tom Rix <trix@redhat.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/fpga/zynqmp-fpga.c | 21 +--------------------
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c
index 4a1139e05280..125743c9797f 100644
--- a/drivers/fpga/zynqmp-fpga.c
+++ b/drivers/fpga/zynqmp-fpga.c
@@ -95,7 +95,6 @@ static int zynqmp_fpga_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct zynqmp_fpga_priv *priv;
struct fpga_manager *mgr;
- int ret;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -108,24 +107,7 @@ static int zynqmp_fpga_probe(struct platform_device *pdev)
if (!mgr)
return -ENOMEM;
- platform_set_drvdata(pdev, mgr);
-
- ret = fpga_mgr_register(mgr);
- if (ret) {
- dev_err(dev, "unable to register FPGA manager");
- return ret;
- }
-
- return 0;
-}
-
-static int zynqmp_fpga_remove(struct platform_device *pdev)
-{
- struct fpga_manager *mgr = platform_get_drvdata(pdev);
-
- fpga_mgr_unregister(mgr);
-
- return 0;
+ return devm_fpga_mgr_register(dev, mgr);
}
static const struct of_device_id zynqmp_fpga_of_match[] = {
@@ -137,7 +119,6 @@ MODULE_DEVICE_TABLE(of, zynqmp_fpga_of_match);
static struct platform_driver zynqmp_fpga_driver = {
.probe = zynqmp_fpga_probe,
- .remove = zynqmp_fpga_remove,
.driver = {
.name = "zynqmp_fpga_manager",
.of_match_table = of_match_ptr(zynqmp_fpga_of_match),
--
2.29.2
next prev parent reply other threads:[~2020-11-15 19:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 19:51 [RESEND PATCH 00/10] Introduce devm_fpga_mgr_register() Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: " Moritz Fischer
2020-11-16 7:10 ` Xu Yilun
2020-11-15 19:51 ` [RESEND PATCH 04/10] fpga: fpga-mgr: ice40-spi: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 05/10] fpga: fpga-mgr: machxo2-spi: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 06/10] fpga: fpga-mgr: socfpga: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 07/10] fpga: fpga-mgr: ts73xx: " Moritz Fischer
2020-11-15 19:51 ` [RESEND PATCH 08/10] fpga: fpga-mgr: xilinx-spi: " Moritz Fischer
2020-11-15 19:51 ` Moritz Fischer [this message]
2020-11-15 19:51 ` [RESEND PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: " Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115195127.284487-10-mdf@kernel.org \
--to=mdf@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).