linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Nava kishore Manne <navam@xilinx.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"mdf@kernel.org" <mdf@kernel.org>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
	git <git@xilinx.com>,
	Appana Durga Kedareswara Rao <appanad@xilinx.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"chinnikishore369@gmail.com" <chinnikishore369@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"trix@redhat.com" <trix@redhat.com>,
	Michal Simek <michals@xilinx.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager
Date: Wed, 17 Feb 2021 15:06:53 -0600	[thread overview]
Message-ID: <20210217210653.GA2752472@robh.at.kernel.org> (raw)
In-Reply-To: <MWHPR02MB2623787A36B389BCF337D8EBC28B9@MWHPR02MB2623.namprd02.prod.outlook.com>

On Fri, Feb 12, 2021 at 06:13:33AM +0000, Nava kishore Manne wrote:
> Hi Rob,
> 
> Please find my response inline.
> 
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Thursday, February 11, 2021 8:26 PM
> > To: Nava kishore Manne <navam@xilinx.com>
> > Cc: linux-arm-kernel@lists.infradead.org; mdf@kernel.org; linux-
> > fpga@vger.kernel.org; git <git@xilinx.com>; Appana Durga Kedareswara Rao
> > <appanad@xilinx.com>; devicetree@vger.kernel.org; robh+dt@kernel.org;
> > chinnikishore369@gmail.com; linux-kernel@vger.kernel.org;
> > trix@redhat.com; Michal Simek <michals@xilinx.com>
> > Subject: Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> > manager
> > 
> > On Thu, 11 Feb 2021 11:35:31 +0530, Nava kishore Manne wrote:
> > > From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> > >
> > > This patch adds binding doc for versal fpga manager driver.
> > >
> > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > > Signed-off-by: Appana Durga Kedareswara rao
> > > <appana.durga.rao@xilinx.com>
> > > ---
> > > Changes for v2:
> > >                 -Fixed file format and syntax issues.
> > >
> > >  .../bindings/fpga/xlnx,versal-fpga.yaml       | 33 +++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> > >
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:12:14:
> > [warning] too many spaces after colon (colons)
> > ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:20:9:
> > [warning] wrong indentation: expected 10 but found 8 (indentation)
> > 
> > dtschema/dtc warnings/errors:
> > 
> > See https://patchwork.ozlabs.org/patch/1439305
> > 
> > This check can fail if there are any dependencies. The base for a patch series
> > is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above error(s),
> > then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> 
> Initially, I couldn't see any issue when I run.
> After installing yamllint and with upgraded dt-schema, I am able to reproduce the above pointed issues.
> Is there any prerequisite(Other than yamllint) I need to follow to run dt-schema?

No, just keeping dtschema up to date.

Rob

  reply	other threads:[~2021-02-17 21:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11  6:05 [PATCH v2 0/3] Add Bitstream configuration support for Versal Nava kishore Manne
2021-02-11  6:05 ` [PATCH v2 1/3] drivers: firmware: Add PDI load API support Nava kishore Manne
2021-02-11  6:05 ` [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager Nava kishore Manne
2021-02-11 14:56   ` Rob Herring
2021-02-12  6:13     ` Nava kishore Manne
2021-02-17 21:06       ` Rob Herring [this message]
2021-02-11  6:05 ` [PATCH v2 3/3] fpga: versal-fpga: Add versal fpga manager driver Nava kishore Manne
2021-02-11  6:23   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217210653.GA2752472@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=appanad@xilinx.com \
    --cc=chinnikishore369@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michals@xilinx.com \
    --cc=navam@xilinx.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).