From: Russ Weight <russell.h.weight@intel.com>
To: mdf@kernel.org, linux-fpga@vger.kernel.org
Cc: trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com,
hao.wu@intel.com, matthew.gerlach@intel.com,
richard.gong@intel.com, Russ Weight <russell.h.weight@intel.com>
Subject: [PATCH v2 0/3] fpga: Use standard class dev_release function
Date: Fri, 21 May 2021 16:00:02 -0700 [thread overview]
Message-ID: <20210521230005.663650-1-russell.h.weight@intel.com> (raw)
The FPGA framework has a convention of using managed resource
functions to allow parent drivers to manage the data structures
allocated by the class drivers. They use an empty *_dev_release()
function to satisfy the class driver.
This is inconsistent with linux driver model.
These changes remove the managed resource functions and populate
the class dev_release callback functions. They also merge the
create and register functions into a single register function for
each of the fpga-mgr, fpga-region, and fpga-bridge class drivers.
For more context, refer to this email thread:
https://marc.info/?l=linux-fpga&m=162127412218557&w=2
I turned on the configs assocated with each of the modified files,
but I must have been missing some dependencies, because not all
of them compiled. I did a run-time test specifically with the
dfl-fme infrastructure. This would have exercised the region,
bridge, and fpga-mgr frameworks.
Changelog v1 -> v2:
- Restored devm_fpga_mgr_register() functionality to the fpga-mgr
class driver, adapted for the combined create/register functionality.
- All previous callers of devm_fpga_mgr_register() will continue to call
devm_fpga_mgr_register().
- replaced unnecessary ternary operators in return statements with
standard if conditions.
Russ Weight (3):
fpga: mgr: Use standard dev_release for class driver
fpga: bridge: Use standard dev_release for class driver
fpga: region: Use standard dev_release for class driver
drivers/fpga/altera-cvp.c | 12 +--
drivers/fpga/altera-fpga2sdram.c | 12 +--
drivers/fpga/altera-freeze-bridge.c | 10 +-
drivers/fpga/altera-hps2fpga.c | 12 +--
drivers/fpga/altera-pr-ip-core.c | 8 +-
drivers/fpga/altera-ps-spi.c | 10 +-
drivers/fpga/dfl-fme-br.c | 10 +-
drivers/fpga/dfl-fme-mgr.c | 10 +-
drivers/fpga/dfl-fme-region.c | 10 +-
drivers/fpga/dfl.c | 10 +-
drivers/fpga/fpga-bridge.c | 113 ++++----------------
drivers/fpga/fpga-mgr.c | 159 +++++++---------------------
drivers/fpga/fpga-region.c | 97 +++--------------
drivers/fpga/ice40-spi.c | 10 +-
drivers/fpga/machxo2-spi.c | 10 +-
drivers/fpga/of-fpga-region.c | 10 +-
drivers/fpga/socfpga-a10.c | 16 ++-
drivers/fpga/socfpga.c | 10 +-
drivers/fpga/stratix10-soc.c | 15 +--
drivers/fpga/ts73xx-fpga.c | 10 +-
drivers/fpga/xilinx-pr-decoupler.c | 17 ++-
drivers/fpga/xilinx-spi.c | 12 +--
drivers/fpga/zynq-fpga.c | 16 ++-
drivers/fpga/zynqmp-fpga.c | 10 +-
include/linux/fpga/fpga-bridge.h | 12 +--
include/linux/fpga/fpga-mgr.h | 17 ++-
include/linux/fpga/fpga-region.h | 12 +--
27 files changed, 185 insertions(+), 465 deletions(-)
--
2.25.1
next reply other threads:[~2021-05-21 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 23:00 Russ Weight [this message]
2021-05-21 23:00 ` [PATCH v2 1/3] fpga: mgr: Use standard dev_release for class driver Russ Weight
2021-05-21 23:00 ` [PATCH v2 2/3] fpga: bridge: " Russ Weight
2021-05-21 23:00 ` [PATCH v2 3/3] fpga: region: " Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521230005.663650-1-russell.h.weight@intel.com \
--to=russell.h.weight@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).