Hi Russ, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.13-rc2 next-20210521] [cannot apply to xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Russ-Weight/fpga-Use-standard-class-dev_release-function/20210522-205631 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47 config: arm64-randconfig-p001-20210522 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/2bd6e6762866ff1b80bea0d0d8377bcf9d2253ce git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Russ-Weight/fpga-Use-standard-class-dev_release-function/20210522-205631 git checkout 2bd6e6762866ff1b80bea0d0d8377bcf9d2253ce # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/fpga/fpga-region.c:193: warning: expecting prototype for fpga_region_create(). Prototype was for fpga_region_register() instead vim +193 drivers/fpga/fpga-region.c 41a8b2c56470b7 Wu Hao 2018-06-30 181 9f368977b4589e Alan Tull 2018-05-16 182 /** 9f368977b4589e Alan Tull 2018-05-16 183 * fpga_region_create - alloc and init a struct fpga_region 9f368977b4589e Alan Tull 2018-05-16 184 * @dev: device parent 9f368977b4589e Alan Tull 2018-05-16 185 * @mgr: manager that programs this region 9f368977b4589e Alan Tull 2018-05-16 186 * @get_bridges: optional function to get bridges to a list 9f368977b4589e Alan Tull 2018-05-16 187 * 2bd6e6762866ff Russ Weight 2021-05-20 188 * Returns a struct fpga_region pointer on success, or ERR_PTR() on error. 9f368977b4589e Alan Tull 2018-05-16 189 */ 2bd6e6762866ff Russ Weight 2021-05-20 190 struct fpga_region * 2bd6e6762866ff Russ Weight 2021-05-20 191 fpga_region_register(struct device *dev, struct fpga_manager *mgr, 9f368977b4589e Alan Tull 2018-05-16 192 int (*get_bridges)(struct fpga_region *)) 0fa20cdfcc1f68 Alan Tull 2016-11-01 @193 { 9f368977b4589e Alan Tull 2018-05-16 194 struct fpga_region *region; 0fa20cdfcc1f68 Alan Tull 2016-11-01 195 int id, ret = 0; 0fa20cdfcc1f68 Alan Tull 2016-11-01 196 9f368977b4589e Alan Tull 2018-05-16 197 region = kzalloc(sizeof(*region), GFP_KERNEL); 9f368977b4589e Alan Tull 2018-05-16 198 if (!region) 2bd6e6762866ff Russ Weight 2021-05-20 199 return ERR_PTR(-ENOMEM); 9f368977b4589e Alan Tull 2018-05-16 200 0fa20cdfcc1f68 Alan Tull 2016-11-01 201 id = ida_simple_get(&fpga_region_ida, 0, 0, GFP_KERNEL); 52a3a7ccce07e7 Alan Tull 2017-11-15 202 if (id < 0) 9f368977b4589e Alan Tull 2018-05-16 203 goto err_free; 0fa20cdfcc1f68 Alan Tull 2016-11-01 204 9f368977b4589e Alan Tull 2018-05-16 205 region->mgr = mgr; 9f368977b4589e Alan Tull 2018-05-16 206 region->get_bridges = get_bridges; 0fa20cdfcc1f68 Alan Tull 2016-11-01 207 mutex_init(®ion->mutex); 0fa20cdfcc1f68 Alan Tull 2016-11-01 208 INIT_LIST_HEAD(®ion->bridge_list); 9f368977b4589e Alan Tull 2018-05-16 209 0fa20cdfcc1f68 Alan Tull 2016-11-01 210 region->dev.class = fpga_region_class; 0fa20cdfcc1f68 Alan Tull 2016-11-01 211 region->dev.parent = dev; 52a3a7ccce07e7 Alan Tull 2017-11-15 212 region->dev.of_node = dev->of_node; 0fa20cdfcc1f68 Alan Tull 2016-11-01 213 region->dev.id = id; 0fa20cdfcc1f68 Alan Tull 2016-11-01 214 0fa20cdfcc1f68 Alan Tull 2016-11-01 215 ret = dev_set_name(®ion->dev, "region%d", id); 0fa20cdfcc1f68 Alan Tull 2016-11-01 216 if (ret) 0fa20cdfcc1f68 Alan Tull 2016-11-01 217 goto err_remove; 0fa20cdfcc1f68 Alan Tull 2016-11-01 218 2bd6e6762866ff Russ Weight 2021-05-20 219 ret = device_register(®ion->dev); 2bd6e6762866ff Russ Weight 2021-05-20 220 if (ret) { 2bd6e6762866ff Russ Weight 2021-05-20 221 put_device(®ion->dev); 2bd6e6762866ff Russ Weight 2021-05-20 222 return ERR_PTR(ret); 2bd6e6762866ff Russ Weight 2021-05-20 223 } 2bd6e6762866ff Russ Weight 2021-05-20 224 9f368977b4589e Alan Tull 2018-05-16 225 return region; 52a3a7ccce07e7 Alan Tull 2017-11-15 226 52a3a7ccce07e7 Alan Tull 2017-11-15 227 err_remove: 52a3a7ccce07e7 Alan Tull 2017-11-15 228 ida_simple_remove(&fpga_region_ida, id); 9f368977b4589e Alan Tull 2018-05-16 229 err_free: 9f368977b4589e Alan Tull 2018-05-16 230 kfree(region); 9f368977b4589e Alan Tull 2018-05-16 231 2bd6e6762866ff Russ Weight 2021-05-20 232 return ERR_PTR(ret); 52a3a7ccce07e7 Alan Tull 2017-11-15 233 } 52a3a7ccce07e7 Alan Tull 2017-11-15 234 EXPORT_SYMBOL_GPL(fpga_region_register); 52a3a7ccce07e7 Alan Tull 2017-11-15 235 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org