From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA58C47094 for ; Thu, 10 Jun 2021 08:23:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68C95613DF for ; Thu, 10 Jun 2021 08:23:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230405AbhFJIZi (ORCPT ); Thu, 10 Jun 2021 04:25:38 -0400 Received: from mga03.intel.com ([134.134.136.65]:8371 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbhFJIZG (ORCPT ); Thu, 10 Jun 2021 04:25:06 -0400 IronPort-SDR: ZFWzdJITDObdWyVDkI5/0KUd5Y/JxrEtTEaxVkmADFgZngpJTZ+xSe5hZONtLX3/TEfkySoqi3 SNVnDlEoVcJg== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="205285101" X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="205285101" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 01:23:10 -0700 IronPort-SDR: KZeedKDyEsd/zce3EwkZkMem3pjfXpy4RsbJyfhz5/4w2TlBC64TjOyoLqetltun9gZtnkKoa6 Np9B/21MO8mw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="638285908" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.162]) by fmsmga005.fm.intel.com with ESMTP; 10 Jun 2021 01:23:08 -0700 Date: Thu, 10 Jun 2021 16:17:28 +0800 From: Xu Yilun To: Russ Weight Cc: mdf@kernel.org, linux-fpga@vger.kernel.org, trix@redhat.com, lgoncalv@redhat.com, hao.wu@intel.com, matthew.gerlach@intel.com, richard.gong@intel.com Subject: Re: [PATCH v2 7/8] fpga: bridge: Use standard dev_release for class driver Message-ID: <20210610081728.GF2007225@yilunxu-OptiPlex-7050> References: <20210609221135.261837-1-russell.h.weight@intel.com> <20210609221135.261837-8-russell.h.weight@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609221135.261837-8-russell.h.weight@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Looks good to me. Reviewed-by: Xu Yilun On Wed, Jun 09, 2021 at 03:11:34PM -0700, Russ Weight wrote: > The FPGA bridge class driver data structure is being treated as a managed > resource instead of using standard dev_release call-back to release the > class data structure. This change populates the class.dev_release function > and changes the fpga_bridge_free() function to call put_device(). It also > changes fpga_bridge_unregister() to call device_del() instead of > device_unregister(). > > Signed-off-by: Russ Weight > --- > v2: > - Moved the renaming of "dev" to "parent" to a separate patch > - Call fpga_bridge_free() in devm_fpga_bridge_release() instead of > put_device() > --- > drivers/fpga/fpga-bridge.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c > index 6c56afc66a6d..b40f4b4228e7 100644 > --- a/drivers/fpga/fpga-bridge.c > +++ b/drivers/fpga/fpga-bridge.c > @@ -340,8 +340,10 @@ struct fpga_bridge *fpga_bridge_create(struct device *parent, const char *name, > return NULL; > > id = ida_simple_get(&fpga_bridge_ida, 0, 0, GFP_KERNEL); > - if (id < 0) > - goto error_kfree; > + if (id < 0) { > + kfree(bridge); > + return NULL; > + } > > mutex_init(&bridge->mutex); > INIT_LIST_HEAD(&bridge->node); > @@ -358,17 +360,12 @@ struct fpga_bridge *fpga_bridge_create(struct device *parent, const char *name, > bridge->dev.id = id; > > ret = dev_set_name(&bridge->dev, "br%d", id); > - if (ret) > - goto error_device; > + if (ret) { > + put_device(&bridge->dev); > + return NULL; > + } > > return bridge; > - > -error_device: > - ida_simple_remove(&fpga_bridge_ida, id); > -error_kfree: > - kfree(bridge); > - > - return NULL; > } > EXPORT_SYMBOL_GPL(fpga_bridge_create); > > @@ -378,8 +375,7 @@ EXPORT_SYMBOL_GPL(fpga_bridge_create); > */ > void fpga_bridge_free(struct fpga_bridge *bridge) > { > - ida_simple_remove(&fpga_bridge_ida, bridge->dev.id); > - kfree(bridge); > + put_device(&bridge->dev); > } > EXPORT_SYMBOL_GPL(fpga_bridge_free); > > @@ -469,12 +465,16 @@ void fpga_bridge_unregister(struct fpga_bridge *bridge) > if (bridge->br_ops && bridge->br_ops->fpga_bridge_remove) > bridge->br_ops->fpga_bridge_remove(bridge); > > - device_unregister(&bridge->dev); > + device_del(&bridge->dev); > } > EXPORT_SYMBOL_GPL(fpga_bridge_unregister); > > static void fpga_bridge_dev_release(struct device *dev) > { > + struct fpga_bridge *bridge = to_fpga_bridge(dev); > + > + ida_simple_remove(&fpga_bridge_ida, bridge->dev.id); > + kfree(bridge); > } > > static int __init fpga_bridge_dev_init(void) > -- > 2.25.1