From: Xu Yilun <yilun.xu@intel.com>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: will@kernel.org, hao.wu@intel.com, mark.rutland@arm.com,
trix@redhat.com, luwei.kang@intel.com, mdf@kernel.org,
linux-fpga@vger.kernel.org, maddy@linux.vnet.ibm.com,
atrajeev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, rnsastry@linux.ibm.com
Subject: Re: [RFC] fpga: dfl: fme: Fix cpu hotplug code
Date: Mon, 28 Jun 2021 17:01:46 +0800 [thread overview]
Message-ID: <20210628090146.GA80012@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20210628071546.167088-1-kjain@linux.ibm.com>
It's a good fix, you can drop the RFC in commit title. :)
The title could be more specific, like:
fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
So we know it is for performance reporting feature at first glance.
On Mon, Jun 28, 2021 at 12:45:46PM +0530, Kajol Jain wrote:
> Commit 724142f8c42a ("fpga: dfl: fme: add performance
> reporting support") added performance reporting support
> for FPGA management engine via perf.
May drop this section, it is indicated in the Fixes tag.
>
> It also added cpu hotplug feature but it didn't add
The performance reporting driver added cpu hotplug ...
> pmu migration call in cpu offline function.
> This can create an issue incase the current designated
> cpu being used to collect fme pmu data got offline,
> as based on current code we are not migrating fme pmu to
> new target cpu. Because of that perf will still try to
> fetch data from that offline cpu and hence we will not
> get counter data.
>
> Patch fixed this issue by adding pmu_migrate_context call
> in fme_perf_offline_cpu function.
>
> Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
Tested-by: Xu Yilun <yilun.xu@intel.com>
Thanks,
Yilun
> ---
> drivers/fpga/dfl-fme-perf.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> ---
> - This fix patch is not tested (as I don't have required environment).
> But issue mentioned in the commit msg can be re-created, by starting any
> fme_perf event and while its still running, offline current designated
> cpu pointed by cpumask file. Since current code didn't migrating pmu,
> perf gonna try getting counts from that offlined cpu and hence we will
> not get event data.
> ---
> diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
> index 4299145ef347..b9a54583e505 100644
> --- a/drivers/fpga/dfl-fme-perf.c
> +++ b/drivers/fpga/dfl-fme-perf.c
> @@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
> return 0;
>
> priv->cpu = target;
> +
> + /* Migrate fme_perf pmu events to the new target cpu */
> + perf_pmu_migrate_context(&priv->pmu, cpu, target);
> +
> return 0;
> }
>
> --
> 2.31.1
next prev parent reply other threads:[~2021-06-28 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 7:15 [RFC] fpga: dfl: fme: Fix cpu hotplug code Kajol Jain
2021-06-28 9:01 ` Xu Yilun [this message]
2021-06-28 10:04 ` kajoljain
2021-06-28 18:40 ` Moritz Fischer
2021-06-29 7:14 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628090146.GA80012@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=hao.wu@intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luwei.kang@intel.com \
--cc=maddy@linux.vnet.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=rnsastry@linux.ibm.com \
--cc=trix@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).