linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Moritz Fischer <mdf@kernel.org>
To: linux-fpga@vger.kernel.org
Cc: trix@redhat.com, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, Moritz Fischer <mdf@kernel.org>
Subject: [PATCH] fpga: versal-fpga: Remove empty functions
Date: Sun, 25 Jul 2021 20:08:06 -0700	[thread overview]
Message-ID: <20210726030806.714809-1-mdf@kernel.org> (raw)

Since the core framework now wraps the functions, ensuring
drives only have to implement functions that do something,
drop the now no longer required callbacks for state and
write_complete.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---

Hi Greg,

This needs to wait for the earlier pull request [1] that introduces the
wrapper functions, allowing drivers to drop the empty ones.

Unfortunately this sort of got of sync with the versal patches getting
picked up before the wrapper changes went in.


- Moritz

[1] https://lore.kernel.org/linux-fpga/YP4kHpn7CDzCYrbU@epycbox.lan/
---
 drivers/fpga/versal-fpga.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c
index 1bd312a31b23..5b0dda304bd2 100644
--- a/drivers/fpga/versal-fpga.c
+++ b/drivers/fpga/versal-fpga.c
@@ -37,22 +37,9 @@ static int versal_fpga_ops_write(struct fpga_manager *mgr,
 	return ret;
 }
 
-static int versal_fpga_ops_write_complete(struct fpga_manager *mgr,
-					  struct fpga_image_info *info)
-{
-	return 0;
-}
-
-static enum fpga_mgr_states versal_fpga_ops_state(struct fpga_manager *mgr)
-{
-	return FPGA_MGR_STATE_UNKNOWN;
-}
-
 static const struct fpga_manager_ops versal_fpga_ops = {
-	.state = versal_fpga_ops_state,
 	.write_init = versal_fpga_ops_write_init,
 	.write = versal_fpga_ops_write,
-	.write_complete = versal_fpga_ops_write_complete,
 };
 
 static int versal_fpga_probe(struct platform_device *pdev)
-- 
2.32.0


             reply	other threads:[~2021-07-26  3:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26  3:08 Moritz Fischer [this message]
2021-07-27 14:40 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726030806.714809-1-mdf@kernel.org \
    --to=mdf@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trix@redhat.com \
    --subject='Re: [PATCH] fpga: versal-fpga: Remove empty functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).