From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77732C433E6 for ; Thu, 11 Mar 2021 14:51:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AD8E64F3F for ; Thu, 11 Mar 2021 14:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233936AbhCKOvM (ORCPT ); Thu, 11 Mar 2021 09:51:12 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:60811 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233504AbhCKOui (ORCPT ); Thu, 11 Mar 2021 09:50:38 -0500 Received: from mail-wm1-f69.google.com ([209.85.128.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lKMe5-0001Ws-0i for linux-fpga@vger.kernel.org; Thu, 11 Mar 2021 14:50:37 +0000 Received: by mail-wm1-f69.google.com with SMTP id 73so4152451wma.3 for ; Thu, 11 Mar 2021 06:50:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uKAiLuqa2i9OZl7ygZkPLgKIbolSbL3Tro2Nub/Uk4Y=; b=K3HvZ+DKJ6r0Pla0pgi+jrnELXuDK38cfhyhYk//ydenDgueeYnB0EhK5c0rQ15UWj lFm//AeJuOcXkGOslfFiKqcgdMHuFgyUK17OfbsUwRT1g+d/fMqEGcwPabLWwlAclt1n MXn2UnW9Hm3MGvTSS7F36vyoHSvwgko9k3VD02GPtvn35o4Gwhd6LJ6J6do+jbeqwKKu tbSzUmBlwBQd+2LYnhMmkRokr6dUHia+2E0lf07k6xOcCV6SWcQFz//6U7U7IkastMco JkxxxgVQZSWe1kkAHN3rUnjTpu3u05PMwHiLWLuVMeFCbmRWJVUgnVVqeQu5R+sjx18n +V3Q== X-Gm-Message-State: AOAM532h14IVQYwSJ2Xrus8SKTVQS/rx1OaVrAUf7WpDFBRs4EXtbfMd IRa+/PAo/vbdtTYrxRMqndU1A5RV46KB7HyjS+njwH8LBQQnBqtMu25uv+1sSlUBdAX/6O8HsV3 PWLU6LSnSvp+/iX86EgRmROl1hbGQkkuMEgiM0mQ= X-Received: by 2002:adf:f852:: with SMTP id d18mr9342152wrq.210.1615474236736; Thu, 11 Mar 2021 06:50:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyesJMeh5P/4D8iW/copAeKCALuE0/kYNU8cA4lvJq7myQHewdqjAfZPd2tqbyUu+ezagHw4g== X-Received: by 2002:adf:f852:: with SMTP id d18mr9342138wrq.210.1615474236553; Thu, 11 Mar 2021 06:50:36 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id 4sm4433053wma.0.2021.03.11.06.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 06:50:36 -0800 (PST) Subject: Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64 To: Arnd Bergmann List-Id: Cc: Tom Rix , Lee Jones , Catalin Marinas , Will Deacon , Dinh Nguyen , Rob Herring , Michael Turquette , Stephen Boyd , Moritz Fischer , Linux ARM , "linux-kernel@vger.kernel.org" , DTML , linux-clk , linux-edac@vger.kernel.org, linux-fpga@vger.kernel.org, Networking , linux-stm32@st-md-mailman.stormreply.com, arm-soc , SoC Team , Olof Johansson References: <20210310083327.480837-1-krzysztof.kozlowski@canonical.com> <20210310083840.481615-1-krzysztof.kozlowski@canonical.com> <20210310094527.GA701493@dell> <35c39c81-08e4-24c8-f683-2fa7a7ea71de@redhat.com> <1c06cb74-f0b0-66e5-a594-ed1ee9bc876e@canonical.com> <52d0489f-0f77-76a2-3269-e3004c6b6c07@canonical.com> From: Krzysztof Kozlowski Message-ID: <30ba7549-c60d-4ee9-3502-b863bca8d3a7@canonical.com> Date: Thu, 11 Mar 2021 15:50:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 11/03/2021 10:14, Arnd Bergmann wrote: > On Thu, Mar 11, 2021 at 8:08 AM Krzysztof Kozlowski > wrote: >> On 10/03/2021 17:42, Arnd Bergmann wrote: >>> On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski >>> wrote: >>>> On 10/03/2021 16:47, Krzysztof Kozlowski wrote: >>>>> This edac Altera driver is very weird... it uses the same compatible >>>>> differently depending whether this is 32-bit or 64-bit (e.g. Stratix >>>>> 10)! On ARMv7 the compatible means for example one IRQ... On ARMv8, we >>>>> have two. It's quite a new code (2019 from Intel), not some ancient >>>>> legacy, so it should never have been accepted... >>>> >>>> Oh, it's not that horrible as it sounds. They actually have different >>>> compatibles for edac driver with these differences (e.g. in interrupts). >>>> They just do not use them and instead check for the basic (common?) >>>> compatible and architecture... Anyway without testing I am not the >>>> person to fix the edac driver. >>> >>> Ok, This should be fixed properly as you describe, but as a quick hack >>> it wouldn't be hard to just change the #ifdef to check for CONFIG_64BIT >>> instead of CONFIG_ARCH_STRATIX10 during the rename of the config >>> symbol. >> >> This would work. The trouble with renaming ARCH_SOCFPGA into >> ARCH_INTEL_SOCFPGA is that still SOCFPGA will appear in many other >> Kconfig symbols or even directory paths. >> >> Let me use ARCH_INTEL_SOCFPGA for 64bit here and renaming of 32bit a >> little bit later. > > Maybe you can introduce a hidden 'ARCH_INTEL_SOCFPGA' option first > and select that from both the 32-bit and the 64-bit platforms in the first step. > > That should decouple the cleanups, so you can change the drivers to > (only) 'depends on ARCH_INTEL_SOCFPGA' before removing the other > names. Sure, let me try that. I have a v3 almost ready. Best regards, Krzysztof