From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C732FC433DB for ; Thu, 4 Mar 2021 13:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99C0264EEC for ; Thu, 4 Mar 2021 13:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234650AbhCDNzb (ORCPT ); Thu, 4 Mar 2021 08:55:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24877 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241722AbhCDNzZ (ORCPT ); Thu, 4 Mar 2021 08:55:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614866039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0NyEIHSiKDUNn/tCXcKmevRHZ06HwkCwpqNQZWo0MOs=; b=Yw7eb/A1WwbR/WMZsThiHfgo2fOB0TwtQgyGZpSSeAzuVcE9vFG+W8A01szYZxQAwOOjsx /yQkAUG7vPbC/lyL47NzdFAOxl/GfFNSM9L5yzzTReChqvUad3mZ3J5Y1E1iVpSMNtkrxw VibH5AlkA8UIJPwlc/zM6wTCoUIFONE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-HMLDKXqbNKSz33sWZUvmDQ-1; Thu, 04 Mar 2021 08:53:58 -0500 X-MC-Unique: HMLDKXqbNKSz33sWZUvmDQ-1 Received: by mail-qk1-f197.google.com with SMTP id i188so6016317qkd.7 for ; Thu, 04 Mar 2021 05:53:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0NyEIHSiKDUNn/tCXcKmevRHZ06HwkCwpqNQZWo0MOs=; b=iYtqCJsPv+GAcgyt9R7333UcqJlIJYaLG7pHdOxjOSJIx2NAKFZaDmwAVOVVbpbdM0 nkn4D4Pl5p+F883A2LFK8JvhioT7Vc6Kvmph4P1zfyZGLLae7+Ym2lvWkCU92yA4cRO0 0gQ+jmQUmjVU+uUeXwF4Qn0OFsedSK31Z+hqz/3xD84mLBJYtgdQiGm8xzGYqTYjGWqr dHrF4V4RxL7Gsi4laYDRkyW909G24ORkCSccEpTwQoBbFHpjToRZG+/piMbTc/rl38Cz DcUb6Lrwy15/+CmtpJO08DHSfJL2P/Kx6lDl/j086r36OSHT/9dwcEtE2cWzLOR79uBk mrkg== X-Gm-Message-State: AOAM533A07bFtuGFh58CFyNrLWRlGux6R0BNlLRkO5szrcKtjgUOWzBs ynqY+IVsD9KOEavboqhoNWoWHQBbKVhuB/d/ZnK1JpeTeqr2jGwIPvjf7ni2/0FLzHJvrcC3L4e wkZqbbKXP7+gCA7KPYUPeog== X-Received: by 2002:a37:d82:: with SMTP id 124mr3866719qkn.311.1614866037896; Thu, 04 Mar 2021 05:53:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGT3yF5xUm79/kr9yt0qZJDs+VrBzXgEskqAkFZtHf49K/GDpC2+i20jQQkNyx9ISwcuGWRA== X-Received: by 2002:a37:d82:: with SMTP id 124mr3866701qkn.311.1614866037696; Thu, 04 Mar 2021 05:53:57 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id m5sm10426198qtu.45.2021.03.04.05.53.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 05:53:57 -0800 (PST) Subject: Re: [PATCH v2 1/2] dt-bindings: fpga: Add compatible value for Xilinx DFX AXI shutdown manager To: Nava kishore Manne , mdf@kernel.org, robh+dt@kernel.org, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chinnikishore369@gmail.com Cc: git@xilinx.com References: <20210211051148.16722-1-nava.manne@xilinx.com> <20210211051148.16722-2-nava.manne@xilinx.com> From: Tom Rix Message-ID: <6e4ff0b7-7f63-46f8-e713-ca07f532336d@redhat.com> Date: Thu, 4 Mar 2021 05:53:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210211051148.16722-2-nava.manne@xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 2/10/21 9:11 PM, Nava kishore Manne wrote: > This patch Adds compatible value for Xilinx Dynamic Function eXchnage(DFX) > AXI Shutdown manager IP. > > Signed-off-by: Nava kishore Manne > --- > Changes for v2: > -Modified the doc and added DFX axi shutdown manager node > example node as suggested by Tom Rix. > > .../bindings/fpga/xilinx-pr-decoupler.txt | 24 ++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > index 4284d293fa61..0acdfa6d62a4 100644 > --- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > @@ -7,13 +7,24 @@ changes from passing through the bridge. The controller can also > couple / enable the bridges which allows traffic to pass through the > bridge normally. > > +Xilinx LogiCORE Dynamic Function eXchange(DFX) AXI shutdown manager > +Softcore is compatible with the Xilinx LogiCORE pr-decoupler. > + > +The Dynamic Function eXchange AXI shutdown manager prevents AXI traffic > +from passing through the bridge. The controller safely handles AXI4MM > +and AXI4-Lite interfaces on a Reconfigurable Partition when it is > +undergoing dynamic reconfiguration, preventing the system deadlock > +that can occur if AXI transactions are interrupted by DFX > + > The Driver supports only MMIO handling. A PR region can have multiple > PR Decouplers which can be handled independently or chained via decouple/ > decouple_status signals. > > Required properties: > - compatible : Should contain "xlnx,pr-decoupler-1.00" followed by > - "xlnx,pr-decoupler" > + "xlnx,pr-decoupler" or > + "xlnx,dfx-axi-shutdown-manager-1.00" followed by > + "xlnx,dfx-axi-shutdown-manager" > - regs : base address and size for decoupler module > - clocks : input clock to IP > - clock-names : should contain "aclk" > @@ -22,6 +33,7 @@ See Documentation/devicetree/bindings/fpga/fpga-region.txt and > Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. > > Example: > +Partial Reconfig Decoupler: > fpga-bridge@100000450 { > compatible = "xlnx,pr-decoupler-1.00", > "xlnx-pr-decoupler"; > @@ -30,3 +42,13 @@ Example: > clock-names = "aclk"; > bridge-enable = <0>; > }; > + > +Dynamic Function eXchange AXI shutdown manager: > + fpga-bridge@100000450 { > + compatible = "xlnx,dfx-axi-shutdown-manager-1.00", > + "xlnx,dfx-axi-shutdown-manager"; > + regs = <0x10000045 0x10>; > + clocks = <&clkc 15>; > + clock-names = "aclk"; > + bridge-enable = <0>; > + }; Thanks for the example. Reviewed-by: Tom Rix