From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA67CC636CD for ; Tue, 7 Feb 2023 13:30:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbjBGN3I (ORCPT ); Tue, 7 Feb 2023 08:29:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231371AbjBGN3H (ORCPT ); Tue, 7 Feb 2023 08:29:07 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 240BB28D0A for ; Tue, 7 Feb 2023 05:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675776491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9btqwAUpHle2BvSwyJKP2IU4aANhcCkTU8iQE6/qdo4=; b=Bgg+pkPjA9o3CYyWjoGLLp7afE8m+TJ7bema9ij9WznQpuSioKZ9L+PRU3GK8m+WKwh/q3 OiJhH8XQvJRRKPYi9aJPV9/y5B14CgJVDV/l9JIkF+bG4ZRcgRsz8SZt/SrIzspaXVJWNd LlRjL4/gTRPYkaVr9vKS2zpK+UzVURw= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-209-SoyBnRT_OOOSxG8qBnsJ0w-1; Tue, 07 Feb 2023 08:28:10 -0500 X-MC-Unique: SoyBnRT_OOOSxG8qBnsJ0w-1 Received: by mail-qk1-f197.google.com with SMTP id q13-20020a37f70d000000b007283b33bfb3so9711000qkj.4 for ; Tue, 07 Feb 2023 05:28:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9btqwAUpHle2BvSwyJKP2IU4aANhcCkTU8iQE6/qdo4=; b=JAaBq9QCeTeisr5cPbwbt3Mahd/5dnLqRWL4IpTfzxhmnbQS/pfEmMp6Bv9z+Pq3xk WeDJnCktzkRq3/6YCSzDr86IKtimeEqAEYe78P8LE1tds0fHnrQMHVspq0GZ8zSdYHHz 5JbMNq6vHDnenbUCwnzhgp9hC6r572+KLT3rz3jc+Q5TreaaBcjUbOQsqDS5024UG7jD SXsq6JAF54hEnxEZbvV3oUFknVdxTBmOO7Q6Kb1LdftPj08ipk9hTS0gd1nEfp/OQ6qb 3fG8REzFMCkoXjXgtlilRK3atGJ76M/HdCChqpvD1j9AnzqFqJdlnUj/KCt5C+UEJyMU 8qAA== X-Gm-Message-State: AO0yUKU68M9wYN+QK8fE2PuhDy9xwLm7cxQlye/YfUOZWq5uEpBZfnom G2ZDmpzsYn7PYWxy3/c5VKzHnmYh+YwAuhLOjvAsVtqlxzrPlgL1RO0LxK0be4uZM4Vwt+odxz4 ZT4XIrow13Kg0arFRM4Nu X-Received: by 2002:a05:622a:651:b0:3b6:3a8f:ecbc with SMTP id a17-20020a05622a065100b003b63a8fecbcmr3794310qtb.66.1675776489782; Tue, 07 Feb 2023 05:28:09 -0800 (PST) X-Google-Smtp-Source: AK7set8/p6FiRxQXpDHQnZ676YJHD2oDI5ZaoxLPFSd1xRwHmRBbhfB1NntMru5EJ2n33lNXX3sVIA== X-Received: by 2002:a05:622a:651:b0:3b6:3a8f:ecbc with SMTP id a17-20020a05622a065100b003b63a8fecbcmr3794289qtb.66.1675776489433; Tue, 07 Feb 2023 05:28:09 -0800 (PST) Received: from [192.168.9.16] (net-2-34-30-183.cust.vodafonedsl.it. [2.34.30.183]) by smtp.gmail.com with ESMTPSA id o5-20020ac80245000000b003ab7aee56a0sm9259630qtg.39.2023.02.07.05.28.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 05:28:09 -0800 (PST) Message-ID: <7ab96897-f9eb-4abd-a453-cac622588469@redhat.com> Date: Tue, 7 Feb 2023 14:28:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC PATCH 1/4] fpga: add initial KUnit test suite To: Russ Weight Cc: Xu Yilun , Wu Hao , Moritz Fischer , Tom Rix , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org References: <20230203170653.414990-1-marpagan@redhat.com> <20230203170653.414990-2-marpagan@redhat.com> <0491c635-1c0f-01a9-6449-0970f7c0c52f@intel.com> Content-Language: en-US From: Marco Pagani In-Reply-To: <0491c635-1c0f-01a9-6449-0970f7c0c52f@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 2023-02-07 02:05, Russ Weight wrote: > Hi Marco, > > I've just started looking at this, but I have a couple of early comments below > Thanks for looking into this. [...] >> --- /dev/null >> +++ b/drivers/fpga/tests/Kconfig >> @@ -0,0 +1,15 @@ >> +config FPGA_KUNIT_TESTS >> + tristate "FPGA KUnit tests" if !KUNIT_ALL_TESTS >> + depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT >> + default KUNIT_ALL_TESTS >> + help >> + Builds unit tests for the FPGA subsystem. This option >> + is not useful for distributions or general kernels, >> + but only for kernel developers working on the FPGA >> + subsystem and its associated drivers. > These lines seem shorter than necessary. You can use up to 75 > characters per line. > I'll reflow the text in the next revision. [...] >> +static struct kunit_case fpga_test_cases[] = { >> + KUNIT_CASE(fpga_base_test), >> + KUNIT_CASE(fpga_pr_test), >> + {}, >> +}; >> + >> +static struct kunit_suite fpga_test_suite = { >> + .name = "fpga-tests", >> + .suite_init = fpga_suite_init, >> + .test_cases = fpga_test_cases, >> +}; >> + >> +kunit_test_suite(fpga_test_suite); > > When I try to build with these patches, I get this error: >> >> ERROR: modpost: missing MODULE_LICENSE() in drivers/fpga/tests/fpga-tests.o > > I was able to fix it by adding this line at the bottom of the file: > >> MODULE_LICENSE("GPL"); > > - Russ > Right, I forgot to add module info macros to the test suite module. I'll add MODULE_LICENSE() in the next revision. Thanks for the feedback, Marco