From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B680C47083 for ; Wed, 2 Jun 2021 20:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 211AE613EE for ; Wed, 2 Jun 2021 20:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbhFBUk7 (ORCPT ); Wed, 2 Jun 2021 16:40:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60979 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbhFBUk7 (ORCPT ); Wed, 2 Jun 2021 16:40:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622666355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E0/XuNlWKmhhWtieuI0wskLS78FwuunVTdLwC/mfCYo=; b=EBx5pfyQKhVVeDRUBc+4TMq4DsuD5Dxt+qI/5T0e96+8zqPzurckzxWyugg+NxYJ8YFCgC Xz9vc0i+ro540sIaoQjjqBnSwjMteaIPZQwONNaYFM83+G1d+Q2P96v33hijZsIsj6U9So rElMRYvv6O+SuPpv4Sz/rLQjgbyVTFM= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-zgqwifLhNMCxPW-p42wDGg-1; Wed, 02 Jun 2021 16:39:14 -0400 X-MC-Unique: zgqwifLhNMCxPW-p42wDGg-1 Received: by mail-oo1-f69.google.com with SMTP id d12-20020a4aeb8c0000b029023bbaaddcbbso2147490ooj.13 for ; Wed, 02 Jun 2021 13:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=E0/XuNlWKmhhWtieuI0wskLS78FwuunVTdLwC/mfCYo=; b=Yz3c2RUgA8UteQTi+wKyDbze2itDEZVG3dv6BMMAKOdphTOuMNk0zRsBnLVa25905a PTDfOu5F4l9+RFtBatOPVRoIMQncz+W2u/Em03KDsDFwVV5afO0pJKdhfeMsUUsl7fkl BGa2huYDu+RqG7ojofS3HAAf4AqiEWIHHcRWSUGcfkhQEaUBT9GTUtsaup1hmSAnKZ7b HxJRZbAdswpQ9ulM3r793V2vekpDQ1QeVUiPofu4bTjxoijphDHo2Na5wN3HUo1XB4e3 4i6qXOsQf3ot9XEAJx9aO8NqGlnNJJTreb/QYL+9LhUjbHtHkRbB+tWKnmVnle1A1f9/ 4YEg== X-Gm-Message-State: AOAM531FJN1MdfsGyGLlSwfhwwZ54UUlpkaXnc+rbrPNOPE+BKkPhwBD Kvot9yK8nUZUMCGDdj6Z0rxbX/vV1Jq8K1/vDuLCSPQzMCZbz7bP+/urmCoLfE7LMtVcy6413z5 oxehprJzXPoGTRXwLI7/Yaw== X-Received: by 2002:a05:6808:992:: with SMTP id a18mr22575062oic.129.1622666353957; Wed, 02 Jun 2021 13:39:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz2ftAStoo/mrE1T7iYy5n/Cf3MyvtNFl5GUaoW1aAg7LQw1zqt3cIXb7KlwxbYx+Nv62ACw== X-Received: by 2002:a05:6808:992:: with SMTP id a18mr22575039oic.129.1622666353816; Wed, 02 Jun 2021 13:39:13 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id h7sm204004ots.44.2021.06.02.13.39.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 13:39:13 -0700 (PDT) Subject: Re: [PATCH 3/3] fpga: region: Adds runtime PM support To: Nava kishore Manne , Moritz Fischer Cc: "robh+dt@kernel.org" , Michal Simek , "linux-fpga@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , git References: <20210402092049.479-1-nava.manne@xilinx.com> <20210402092049.479-4-nava.manne@xilinx.com> From: Tom Rix Message-ID: <8c7b7fcc-211c-3c22-a105-8c77156fde81@redhat.com> Date: Wed, 2 Jun 2021 13:39:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 6/2/21 3:48 AM, Nava kishore Manne wrote: > Ping! > >> -----Original Message----- >> From: Nava kishore Manne >> Sent: Monday, April 19, 2021 10:49 AM >> To: Moritz Fischer >> Cc: trix@redhat.com; robh+dt@kernel.org; Michal Simek >> ; linux-fpga@vger.kernel.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; git >> Subject: RE: [PATCH 3/3] fpga: region: Adds runtime PM support >> >> Hi Moritz, >> >> Please find my response inline. >> >>> -----Original Message----- >>> From: Moritz Fischer >>> Sent: Saturday, April 10, 2021 3:01 AM >>> To: Nava kishore Manne >>> Cc: mdf@kernel.org; trix@redhat.com; robh+dt@kernel.org; Michal Simek >>> ; linux-fpga@vger.kernel.org; >>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- >>> kernel@lists.infradead.org; git >>> Subject: Re: [PATCH 3/3] fpga: region: Adds runtime PM support >>> >>> On Fri, Apr 02, 2021 at 02:50:49PM +0530, Nava kishore Manne wrote: >>>> Adds support to handle FPGA/PL power domain. With this patch, the PL >>>> power domain will be turned on before loading the bitstream and >>>> turned off while removing/unloading the bitstream using overlays. >>>> This can be achieved by adding the runtime PM support. >>>> >>>> Signed-off-by: Nava kishore Manne >>>> --- >>>> drivers/fpga/of-fpga-region.c | 18 +++++++++++++++++- >>>> 1 file changed, 17 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/fpga/of-fpga-region.c >>>> b/drivers/fpga/of-fpga-region.c index e405309baadc..35fc2f3d4bd8 >>>> 100644 >>>> --- a/drivers/fpga/of-fpga-region.c >>>> +++ b/drivers/fpga/of-fpga-region.c >>>> @@ -15,6 +15,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> >>>> static const struct of_device_id fpga_region_of_match[] = { >>>> { .compatible = "fpga-region", }, >>>> @@ -302,6 +303,7 @@ static int >>>> of_fpga_region_notify_pre_apply(struct >>> fpga_region *region, >>>> } >>>> >>>> region->info = info; >>>> + pm_runtime_get_sync(dev->parent); >>>> ret = fpga_region_program_fpga(region); >>>> if (ret) { >>>> /* error; reject overlay */ >>>> @@ -324,10 +326,13 @@ static int >>>> of_fpga_region_notify_pre_apply(struct fpga_region *region, static >>>> void >>> of_fpga_region_notify_post_remove(struct fpga_region *region, >>>> struct of_overlay_notify_data >>> *nd) { >>>> + struct device *dev = ®ion->dev; >>>> + >>>> fpga_bridges_disable(®ion->bridge_list); >>>> fpga_bridges_put(®ion->bridge_list); >>>> fpga_image_info_free(region->info); >>>> region->info = NULL; >>>> + pm_runtime_put(dev->parent); >>>> } >>>> >>>> /** >>>> @@ -411,9 +416,16 @@ static int of_fpga_region_probe(struct >>> platform_device *pdev) >>>> goto eprobe_mgr_put; >>>> } >>>> >>>> + pm_runtime_enable(&pdev->dev); >>>> + ret = pm_runtime_get_sync(&pdev->dev); >>>> + if (ret < 0) >>>> + goto err_pm; >>>> + >>>> + pm_runtime_put(&pdev->dev); >>>> + >>>> ret = fpga_region_register(region); >>>> if (ret) >>>> - goto eprobe_mgr_put; >>>> + goto err_pm; >>>> >>>> of_platform_populate(np, fpga_region_of_match, NULL, ®ion- >>>> dev); >>>> platform_set_drvdata(pdev, region); @@ -422,6 +434,9 @@ static >>>> int of_fpga_region_probe(struct platform_device *pdev) >>>> >>>> return 0; >>>> >>>> +err_pm: >>>> + pm_runtime_put(&pdev->dev); >>>> + pm_runtime_disable(&pdev->dev); >>>> eprobe_mgr_put: >>>> fpga_mgr_put(mgr); >>>> return ret; >>>> @@ -434,6 +449,7 @@ static int of_fpga_region_remove(struct >>>> platform_device *pdev) >>>> >>>> fpga_region_unregister(region); >>>> fpga_mgr_put(mgr); >>>> + pm_runtime_disable(region->dev.parent); >>>> >>>> return 0; >>>> } >>>> -- >>>> 2.18.0 >>>> >>> Does this add a dependency on CONFIG_PM? >>> >> Yes, the newly added functionality has a dependency on CONFIG_PM if it's >> disabled the expected power domain (in our cases it's PL) will not powered >> ON/OFF dynamically at runtime and this is as an expected behavior. Other >> than this it will not impact the any of the driver existing functionality. This looks like a general change for a specific board. Why can't this be done at the board level ? Tom >> >> Regards, >> Navakishore.