From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBC8C49361 for ; Thu, 17 Jun 2021 13:21:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95093613BA for ; Thu, 17 Jun 2021 13:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232274AbhFQNXU (ORCPT ); Thu, 17 Jun 2021 09:23:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28288 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232215AbhFQNXU (ORCPT ); Thu, 17 Jun 2021 09:23:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623936072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hwGEMKYQQJMv/CxGUZtjWsZj084biuCitqUYtWHA6Pc=; b=SbT6Rq2wr70xNljJsepBHFnr36aOz9Yt58BMlAMeB6IAUS3OUuKStDlrbjwc01JWMGhXjp KPSYSBPwR+qDyCyo61Q6H7hHE78ys/tgQdjkFxBP+zsKnFUkBowJsDi4FEvCObVhSAOCf0 g0W7bvrPbqS3bUY/GFERMl+X5XlCfh4= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-_Fc886sCNNereKRTZxROrg-1; Thu, 17 Jun 2021 09:21:10 -0400 X-MC-Unique: _Fc886sCNNereKRTZxROrg-1 Received: by mail-oo1-f71.google.com with SMTP id n13-20020a4ae1cd0000b029024af40d0cc4so3921133oot.7 for ; Thu, 17 Jun 2021 06:21:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=hwGEMKYQQJMv/CxGUZtjWsZj084biuCitqUYtWHA6Pc=; b=GEeBHrAdM/MT6tqXrctCtBhH+ZWzDoTdwEJd8p1Bn3ytyfM2xkM7XQwCFEIkH1ZyKB ACuenxPzkMEHYTOIc8nWcTChJc/UgrIJk7zAKOyc2b5+C8pLZDziCoEvFILLRBuSnIuR fPk0wKYzDEKu8RrEN+7x82eghk+olIwoxhE7erc0IHeD7PjJeNUrb2xwjM6zsVnrPy3E 5wQIsmyH6XAa6ljJA8Qk5gZz1hmvoVf/7NgVYQUtJJDrQp2p7ehHkmFUV0PU2jTAMqjx srBUpjxqtn3MUwM1Zdtx7vf9CerYlTM642ZTeifpb+Qak2/Oyvljw2gAs5aiZcQ0NT3L CfIA== X-Gm-Message-State: AOAM5305tSgyRmpubJTbo1p3Hez+sxWVaVoNIezg3hXNVhdQfiKuPsZm yeykBljDG5nQtHdsPHvf1699mUf1XzsmV641rfrn7EXqOJ+7MbKR6xpx3KiQXzpCSIngpcSafUx ksctyb9iRS69Jwl6HS2bj1A== X-Received: by 2002:a05:6808:1486:: with SMTP id e6mr10274747oiw.9.1623936070109; Thu, 17 Jun 2021 06:21:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw931LqYJItw0hcQXVJGwWvQ9NYX/nBhC2hX9cM9jm2EmErBb/zfH6Daxmhleh0YKe15pmFdA== X-Received: by 2002:a05:6808:1486:: with SMTP id e6mr10274728oiw.9.1623936069920; Thu, 17 Jun 2021 06:21:09 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id e23sm1264022otk.67.2021.06.17.06.21.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 06:21:09 -0700 (PDT) Subject: Re: [PATCH v4 1/4] fpga: dfl: reorganize to subdir layout To: "Wu, Hao" , Moritz Fischer Cc: "corbet@lwn.net" , "michal.simek@xilinx.com" , "gregkh@linuxfoundation.org" , "krzysztof.kozlowski@canonical.com" , "nava.manne@xilinx.com" , "Xu, Yilun" , "davidgow@google.com" , "fpacheco@redhat.com" , "Gong, Richard" , "luca@lucaceresoli.net" , "linux-fpga@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20210614201648.3358206-1-trix@redhat.com> <20210614201648.3358206-3-trix@redhat.com> From: Tom Rix Message-ID: <9c527087-3646-2f22-1234-2b0247511cc9@redhat.com> Date: Thu, 17 Jun 2021 06:21:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 6/17/21 1:34 AM, Wu, Hao wrote: >> On Wed, Jun 16, 2021 at 01:05:36AM +0000, Wu, Hao wrote: >>>> On 6/15/21 1:08 AM, Wu, Hao wrote: >>>>>> Subject: [PATCH v4 1/4] fpga: dfl: reorganize to subdir layout >>>>>> >>>>>> From: Tom Rix >>>>>> >>>>>> Follow drivers/net/ethernet/ which has control configs >>>>>> NET_VENDOR_BLA that map to drivers/net/ethernet/bla >>>>>> Since fpgas do not have many vendors, drop the 'VENDOR' and use >>>>>> FPGA_BLA. >>>>> Hi Tom, >>>>> >>>>> Thanks for this patch. : ) >>>>> >>>>> DFL is not a vendor, but something can be shared/reused. It's possible that >>>>> other vendors reuse the same concepts and the drivers of DFL. If vendor >>>>> drivers need to be moved inside sub folders, then maybe it's better to >>>>> leave DFL in the parent folder? >>>> xrt is also not a vendor, more a subdevice framework like dfl. >>>> >>>> I am not sure what you mean by other dfl vendors can you give an example ? >>> It's fine, but the description here is a little confusing on vendor/framework >>> handling. No other vendor so far, but it's possible, DFL can be used in >>> non-intel device, and related drivers can be reused as well. Then a fpga >>> mgr driver depends on DFL, should be put inside dfl folder or new >>> vendor's subfolder? >>> >>> Hao >>> >> I'm somewhat neutral on this. If someone non-intel starts using DFL we could >> also >> move the common parts back ... > That's fine. > >> That being said, I'm not super convinced we have to move stuff in the >> first place. > I remember that the first submission of our code is having everything inside a sub > folder, but was suggested that to have everything moved out, this is why we have > dfl files here now. To be honest, I have the similar feeling as you, I didn't see any > strong reason to make this something we must do, but both solutions should be > fine. : ) xrt is bringing in the subdir xrt/ Even after the likely move of xrt subdevices to other subsystems, there will be about as many files in fpga/xrt/ as in fpga/ If both of you are fine with a mixed files and subdir organization, then I'll drop this patchset. If you want only files, then xrt needs to refactor, so let them know. Tom > Thanks > Hao > >> - Moritz