From: Rob Herring <robh@kernel.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org,
Michal Simek <michal.simek@xilinx.com>,
devicetree@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH 4/5] dt-bindings: fpga: xilinx-slave-serial: add optional INIT_B GPIO
Date: Thu, 18 Jun 2020 12:07:32 -0600 [thread overview]
Message-ID: <CAL_JsqLCYdRci2W3otAwz_rDKQeFXuOdO0ZAv4fUGNZoiZb6hg@mail.gmail.com> (raw)
In-Reply-To: <b2c064c0-9a52-890d-b026-9cc1f4cab7d0@lucaceresoli.net>
On Wed, Jun 17, 2020 at 11:47 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
>
> Hi Rob, Moritz,
>
> On 18/06/20 00:39, Rob Herring wrote:
> > On Thu, Jun 11, 2020 at 11:11:43PM +0200, Luca Ceresoli wrote:
> >> The INIT_B is used by the 6 and 7 series to report the programming status,
> >> providing more control and information about programming errors.
> >>
> >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> >> ---
> >> .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 7 ++++++-
> >> 1 file changed, 6 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt
> >> index 9f103f3872e8..a049082e1513 100644
> >> --- a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt
> >> +++ b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt
> >> @@ -16,6 +16,10 @@ Required properties:
> >> - prog_b-gpios: config pin (referred to as PROGRAM_B in the manual)
> >> - done-gpios: config status pin (referred to as DONE in the manual)
> >>
> >> +Optional properties:
> >> +- init_b-gpios: initialization status and configuration error pin
> >> + (referred to as INIT_B in the manual)
> >
> > Don't use '_' in property names:
> >
> > init-b-gpios
>
> OK, will fix.
>
> Moritz, please don't apply this version of patches 4 and 5 if you still
> haven't done so.
>
> Now what about the existing prog_b-gpios property? Should we just leave
> it as is for backward compatibility, or is there a migration path to fix
> it as well?
Just leave it.
Rob
next prev parent reply other threads:[~2020-06-18 18:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 21:11 [PATCH 1/5] dt-bindings: fpga: xilinx-slave-serial: valid for the 7 Series too Luca Ceresoli
2020-06-11 21:11 ` [PATCH 2/5] fpga manager: xilinx-spi: " Luca Ceresoli
2020-06-19 1:38 ` Moritz Fischer
2020-06-11 21:11 ` [PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables Luca Ceresoli
2020-06-19 1:38 ` Moritz Fischer
2020-06-11 21:11 ` [PATCH 4/5] dt-bindings: fpga: xilinx-slave-serial: add optional INIT_B GPIO Luca Ceresoli
2020-06-17 22:39 ` Rob Herring
2020-06-18 5:47 ` Luca Ceresoli
2020-06-18 18:07 ` Rob Herring [this message]
2020-06-11 21:11 ` [PATCH 5/5] fpga manager: xilinx-spi: check INIT_B pin during write_init Luca Ceresoli
2020-06-16 4:43 ` Moritz Fischer
2020-06-16 4:42 ` [PATCH 1/5] dt-bindings: fpga: xilinx-slave-serial: valid for the 7 Series too Moritz Fischer
2020-06-17 22:38 ` Rob Herring
2020-06-19 1:37 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLCYdRci2W3otAwz_rDKQeFXuOdO0ZAv4fUGNZoiZb6hg@mail.gmail.com \
--to=robh@kernel.org \
--cc=agust@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).