From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 References: <20180912144327.3130-1-atull@kernel.org> <20180912144327.3130-5-atull@kernel.org> <20180930154921.GB13200@kroah.com> In-Reply-To: <20180930154921.GB13200@kroah.com> From: Alan Tull Date: Mon, 12 Nov 2018 09:48:00 -0600 Message-ID: Subject: Re: [PATCH 4/5] fpga: of-fpga-region: Use platform_set_drvdata Content-Type: text/plain; charset="UTF-8" To: Greg Kroah-Hartman Cc: Moritz Fischer , linux-kernel , linux-fpga@vger.kernel.org List-ID: On Sun, Sep 30, 2018 at 10:49 AM Greg Kroah-Hartman wrote: Hi Greg, > > On Wed, Sep 12, 2018 at 09:43:26AM -0500, Alan Tull wrote: > > From: Moritz Fischer > > > > Use platform_set_drvdata rather than dev_set_drvdata > > to match the platform_get_drvdata in the _remove() > > function of the platform driver. > > > > Signed-off-by: Moritz Fischer > > Acked-by: Alan Tull > > --- > > drivers/fpga/of-fpga-region.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c > > index 052a134..d6a70e4 100644 > > --- a/drivers/fpga/of-fpga-region.c > > +++ b/drivers/fpga/of-fpga-region.c > > @@ -421,7 +421,7 @@ static int of_fpga_region_probe(struct platform_device *pdev) > > goto eprobe_free; > > > > of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev); > > - dev_set_drvdata(dev, region); > > + platform_set_drvdata(pdev, region); > > Again, not really a bugfix :) Could you take this patch 4/5 (just sent a reminder for 5/5)? Thanks Alan