From: "Wu, Hao" <hao.wu@intel.com>
To: Moritz Fischer <mdf@kernel.org>, "Xu, Yilun" <yilun.xu@intel.com>
Cc: "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"trix@redhat.com" <trix@redhat.com>,
"lgoncalv@redhat.com" <lgoncalv@redhat.com>
Subject: RE: [PATCH v2 3/4] fpga: dfl: fix the comments of type & feature_id fields
Date: Tue, 15 Sep 2020 04:42:22 +0000 [thread overview]
Message-ID: <DM6PR11MB381993E3210D83554558683A85200@DM6PR11MB3819.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200915035945.GC2217@epycbox.lan>
> On Tue, Sep 15, 2020 at 11:27:52AM +0800, Xu Yilun wrote:
> > The description of feature_id in struct dfl_device is not accurate. In
> > DFL specification the feature_id is the 12 bits field. The description
> > in struct dfl_device_id is more clear so we make them aligned. We also
> > made the similar fix for the type field.
> >
> > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Acked-by: Wu Hao <hao.wu@intel.com>
Thanks
Hao
> > ---
> > drivers/fpga/dfl.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> > index 3c69596..d5e050a 100644
> > --- a/drivers/fpga/dfl.h
> > +++ b/drivers/fpga/dfl.h
> > @@ -531,8 +531,8 @@ enum dfl_id_type {
> > *
> > * @dev: generic device interface.
> > * @id: id of the dfl device.
> > - * @type: type of DFL FIU of the device. See enum dfl_id_type.
> > - * @feature_id: 16 bits feature identifier local to its DFL FIU type.
> > + * @type: contains 4 bits DFL FIU type of the device. See enum dfl_id_type.
> > + * @feature_id: contains 12 bits feature identifier local to its DFL FIU type.
> > * @mmio_res: mmio resource of this dfl device.
> > * @irqs: list of Linux IRQ numbers of this dfl device.
> > * @num_irqs: number of IRQs supported by this dfl device.
> > --
> > 2.7.4
> >
>
> Applied to for-next,
>
> Thanks
next prev parent reply other threads:[~2020-09-15 4:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 3:27 [PATCH v2 0/4] add DFL bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-09-15 3:27 ` [PATCH v2 1/4] fpga: dfl: move dfl_device_id to mod_devicetable.h Xu Yilun
2020-09-15 3:59 ` Moritz Fischer
2020-09-15 3:27 ` [PATCH v2 2/4] dfl: add dfl bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-09-15 3:59 ` Moritz Fischer
[not found] ` <DM6PR11MB381970CD3C77534AA3E4C76385200@DM6PR11MB3819.namprd11.prod.outlook.com>
2020-09-15 5:19 ` Xu Yilun
[not found] ` <DM6PR11MB3819106F9D50E39F7CC7837D85200@DM6PR11MB3819.namprd11.prod.outlook.com>
2020-09-15 18:07 ` Moritz Fischer
2020-09-16 0:24 ` Xu Yilun
2020-09-15 3:27 ` [PATCH v2 3/4] fpga: dfl: fix the comments of type & feature_id fields Xu Yilun
2020-09-15 3:59 ` Moritz Fischer
2020-09-15 4:42 ` Wu, Hao [this message]
2020-09-15 3:27 ` [PATCH v2 4/4] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h Xu Yilun
2020-09-15 22:55 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB381993E3210D83554558683A85200@DM6PR11MB3819.namprd11.prod.outlook.com \
--to=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).