* [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR
@ 2023-02-08 8:08 Ilpo Järvinen
2023-02-08 19:28 ` Russ Weight
0 siblings, 1 reply; 3+ messages in thread
From: Ilpo Järvinen @ 2023-02-08 8:08 UTC (permalink / raw)
To: Russ Weight, Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix,
Lee Jones, Ilpo Järvinen, Tianfei zhang, linux-fpga,
linux-kernel
rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
normal -Exxxx codes. Convert <0 return from ->rsu_status() to
FW_UPLOAD_ERR_HW_ERROR.
Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
index f0acedc80182..d7e2f9f461bc 100644
--- a/drivers/fpga/intel-m10-bmc-sec-update.c
+++ b/drivers/fpga/intel-m10-bmc-sec-update.c
@@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
ret = sec->ops->rsu_status(sec);
if (ret < 0)
- return ret;
+ return FW_UPLOAD_ERR_HW_ERROR;
status = ret;
if (!rsu_status_ok(status)) {
--
tg: (97f5496f1624..) sec/fix-error-return-code (depends on: sec/flashops-n6000)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR
2023-02-08 8:08 [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR Ilpo Järvinen
@ 2023-02-08 19:28 ` Russ Weight
2023-02-10 9:24 ` Xu Yilun
0 siblings, 1 reply; 3+ messages in thread
From: Russ Weight @ 2023-02-08 19:28 UTC (permalink / raw)
To: Ilpo Järvinen, Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix,
Lee Jones, Tianfei zhang, linux-fpga, linux-kernel
On 2/8/23 00:08, Ilpo Järvinen wrote:
> rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
> normal -Exxxx codes. Convert <0 return from ->rsu_status() to
> FW_UPLOAD_ERR_HW_ERROR.
>
> Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> ---
> drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> index f0acedc80182..d7e2f9f461bc 100644
> --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
>
> ret = sec->ops->rsu_status(sec);
> if (ret < 0)
> - return ret;
> + return FW_UPLOAD_ERR_HW_ERROR;
> status = ret;
>
> if (!rsu_status_ok(status)) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR
2023-02-08 19:28 ` Russ Weight
@ 2023-02-10 9:24 ` Xu Yilun
0 siblings, 0 replies; 3+ messages in thread
From: Xu Yilun @ 2023-02-10 9:24 UTC (permalink / raw)
To: Russ Weight
Cc: Ilpo Järvinen, Moritz Fischer, Wu Hao, Tom Rix, Lee Jones,
Tianfei zhang, linux-fpga, linux-kernel
On 2023-02-08 at 11:28:26 -0800, Russ Weight wrote:
>
> On 2/8/23 00:08, Ilpo Järvinen wrote:
> > rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
> > normal -Exxxx codes. Convert <0 return from ->rsu_status() to
> > FW_UPLOAD_ERR_HW_ERROR.
> >
> > Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
>
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> >
> > ---
> > drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> > index f0acedc80182..d7e2f9f461bc 100644
> > --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> > +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> > @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
> >
> > ret = sec->ops->rsu_status(sec);
> > if (ret < 0)
> > - return ret;
> > + return FW_UPLOAD_ERR_HW_ERROR;
> > status = ret;
> >
> > if (!rsu_status_ok(status)) {
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-10 9:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 8:08 [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR Ilpo Järvinen
2023-02-08 19:28 ` Russ Weight
2023-02-10 9:24 ` Xu Yilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).