From: Moritz Fischer <mdf@kernel.org>
To: Russ Weight <russell.h.weight@intel.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, trix@redhat.com,
lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com,
matthew.gerlach@intel.com, richard.gong@intel.com
Subject: Re: [PATCH v12 5/7] fpga: sec-mgr: expose sec-mgr update size
Date: Mon, 10 May 2021 10:39:40 -0700 [thread overview]
Message-ID: <YJlv3DFvpOJYUUni@epycbox.lan> (raw)
In-Reply-To: <20210503213546.316439-6-russell.h.weight@intel.com>
On Mon, May 03, 2021 at 02:35:44PM -0700, Russ Weight wrote:
> Extend the FPGA Security Manager class driver to include
> an update/remaining_size sysfs node that can be read to
> determine how much data remains to be transferred to the
> secure update engine. This file can be used to monitor
> progress during the "writing" phase of an update.
>
> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> ---
> v12:
> - Updated Date and KernelVersion fields in ABI documentation
> v11:
> - No change
> v10:
> - Rebased to 5.12-rc2 next
> - Updated Date and KernelVersion in ABI documentation
> v9:
> - Updated Date and KernelVersion in ABI documentation
> v8:
> - No change
> v7:
> - Changed Date in documentation file to December 2020
> v6:
> - No change
> v5:
> - Use new function sysfs_emit() in the remaining_size_show() function
> v4:
> - Changed from "Intel FPGA Security Manager" to FPGA Security Manager"
> and removed unnecessary references to "Intel".
> - Changed: imgr -> smgr, ifpga_ to fpga_
> v3:
> - No change
> v2:
> - Bumped documentation date and version
> ---
> Documentation/ABI/testing/sysfs-class-fpga-sec-mgr | 11 +++++++++++
> drivers/fpga/fpga-sec-mgr.c | 10 ++++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr b/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr
> index 24890d04521f..c5d0b9d7c7e4 100644
> --- a/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr
> +++ b/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr
> @@ -28,6 +28,17 @@ Description: Read-only. Returns a string describing the current
> as it will be signaled by sysfs_notify() on each
> state change.
>
> +What: /sys/class/fpga_sec_mgr/fpga_secX/update/remaining_size
> +Date: June 2021
> +KernelVersion: 5.14
> +Contact: Russ Weight <russell.h.weight@intel.com>
> +Description: Read-only. Returns the size of data that remains to
> + be written to the secure update engine. The size
> + value is initialized to the full size of the file
> + image and the value is updated periodically during
> + the "writing" phase of the update.
> + Format: "%u".
> +
> What: /sys/class/fpga_sec_mgr/fpga_secX/update/error
> Date: June 2021
> KernelVersion: 5.14
> diff --git a/drivers/fpga/fpga-sec-mgr.c b/drivers/fpga/fpga-sec-mgr.c
> index e43fa2797d27..2487042ace82 100644
> --- a/drivers/fpga/fpga-sec-mgr.c
> +++ b/drivers/fpga/fpga-sec-mgr.c
> @@ -198,6 +198,15 @@ error_show(struct device *dev, struct device_attribute *attr, char *buf)
> }
> static DEVICE_ATTR_RO(error);
>
> +static ssize_t remaining_size_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct fpga_sec_mgr *smgr = to_sec_mgr(dev);
> +
> + return sysfs_emit(buf, "%u\n", smgr->remaining_size);
> +}
> +static DEVICE_ATTR_RO(remaining_size);
> +
> static ssize_t filename_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> @@ -234,6 +243,7 @@ static struct attribute *sec_mgr_update_attrs[] = {
> &dev_attr_filename.attr,
> &dev_attr_status.attr,
> &dev_attr_error.attr,
> + &dev_attr_remaining_size.attr,
> NULL,
> };
>
> --
> 2.25.1
>
Looks good,
Moritz
next prev parent reply other threads:[~2021-05-10 17:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 21:35 [PATCH v12 0/7] FPGA Security Manager Class Driver Russ Weight
2021-05-03 21:35 ` [PATCH v12 1/7] fpga: sec-mgr: fpga security manager class driver Russ Weight
2021-05-10 17:28 ` Moritz Fischer
2021-05-03 21:35 ` [PATCH v12 2/7] fpga: sec-mgr: enable secure updates Russ Weight
2021-05-10 17:32 ` Moritz Fischer
2021-05-03 21:35 ` [PATCH v12 3/7] fpga: sec-mgr: expose sec-mgr update status Russ Weight
2021-05-10 17:36 ` Moritz Fischer
2021-05-03 21:35 ` [PATCH v12 4/7] fpga: sec-mgr: expose sec-mgr update errors Russ Weight
2021-05-10 17:39 ` Moritz Fischer
2021-05-03 21:35 ` [PATCH v12 5/7] fpga: sec-mgr: expose sec-mgr update size Russ Weight
2021-05-10 17:39 ` Moritz Fischer [this message]
2021-05-03 21:35 ` [PATCH v12 6/7] fpga: sec-mgr: enable cancel of secure update Russ Weight
2021-05-10 17:40 ` Moritz Fischer
2021-05-03 21:35 ` [PATCH v12 7/7] fpga: sec-mgr: expose hardware error info Russ Weight
2021-05-10 17:41 ` Moritz Fischer
2021-05-10 14:12 ` [PATCH v12 0/7] FPGA Security Manager Class Driver Tom Rix
2021-05-10 17:37 ` Moritz Fischer
2021-05-10 18:52 ` Tom Rix
2021-05-14 16:33 ` Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJlv3DFvpOJYUUni@epycbox.lan \
--to=mdf@kernel.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=richard.gong@intel.com \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).