From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B224AC47095 for ; Wed, 9 Jun 2021 09:59:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E23D613AC for ; Wed, 9 Jun 2021 09:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234321AbhFIKBQ (ORCPT ); Wed, 9 Jun 2021 06:01:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:44558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233817AbhFIKBP (ORCPT ); Wed, 9 Jun 2021 06:01:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0AE27610C7; Wed, 9 Jun 2021 09:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623232760; bh=265X25GE4eApAM6xlZqmIshxEVIqMbQhtZIqjtCnlBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hSfsxRI8do3bXAQ/Hz/dyk02xEU7BgVuNfX27QeJZrVOgg+YbtdX44b9HcMNVPbH3 uRtFPaFPAxW/SUh6J3mieCqdgLVaw3jiTdsVBf9BT4m8e8EYJk68l/u52WDVM7B+yq Jy0zCtGbFmbg2/CzSqfAvke43lXYH/3IBdeIDVys= Date: Wed, 9 Jun 2021 11:59:18 +0200 From: Greg KH To: trix@redhat.com Cc: mdf@kernel.org, michal.simek@xilinx.com, nava.manne@xilinx.com, luca@lucaceresoli.net, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files Message-ID: References: <20210608162551.3010533-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608162551.3010533-1-trix@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote: > From: Tom Rix > > It is not necessary to have a xilinx- prefix on a file > when the file is in a xilinx/ subdir. > > Signed-off-by: Tom Rix > --- > drivers/fpga/xilinx/Makefile | 4 ++-- > drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 > drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 > 3 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) > rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%) > > diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile > index 7bb7543412790..4ac727d03e140 100644 > --- a/drivers/fpga/xilinx/Makefile > +++ b/drivers/fpga/xilinx/Makefile > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > > -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o > -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o > +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o > +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o You just renamed the module to be called "spi.ko"???? Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok. greg k-h