From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Rix <trix@redhat.com>
Cc: mdf@kernel.org, michal.simek@xilinx.com, nava.manne@xilinx.com,
luca@lucaceresoli.net, linux-fpga@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files
Date: Wed, 9 Jun 2021 16:57:06 +0200 [thread overview]
Message-ID: <YMDWwjnCAMNMH94W@kroah.com> (raw)
In-Reply-To: <ec407ae2-ea5a-5c97-aea6-1ba2451116b7@redhat.com>
On Wed, Jun 09, 2021 at 06:27:05AM -0700, Tom Rix wrote:
>
> On 6/9/21 2:59 AM, Greg KH wrote:
> > On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > It is not necessary to have a xilinx- prefix on a file
> > > when the file is in a xilinx/ subdir.
> > >
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > ---
> > > drivers/fpga/xilinx/Makefile | 4 ++--
> > > drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
> > > drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0
> > > 3 files changed, 2 insertions(+), 2 deletions(-)
> > > rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
> > > rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)
> > >
> > > diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile
> > > index 7bb7543412790..4ac727d03e140 100644
> > > --- a/drivers/fpga/xilinx/Makefile
> > > +++ b/drivers/fpga/xilinx/Makefile
> > > @@ -1,7 +1,7 @@
> > > # SPDX-License-Identifier: GPL-2.0
> > > -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
> > > -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
> > > +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
> > > +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o
> > You just renamed the module to be called "spi.ko"????
> >
> > Did you test this thing? You can not rename modules without good
> > reasons, and calling a device specific kernel module "spi.ko" is not ok.
>
> yes, this is a problem, I will drop the renaming patches.
So you didn't test these?
Again, why is this file movement necessary?
next prev parent reply other threads:[~2021-06-09 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 16:25 [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files trix
2021-06-09 9:59 ` Greg KH
2021-06-09 13:27 ` Tom Rix
2021-06-09 14:57 ` Greg KH [this message]
2021-06-09 13:21 [PATCH 0/7] fpga: reorganize to subdirs trix
2021-06-09 13:21 ` [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files trix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMDWwjnCAMNMH94W@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).