From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F8AFC48BCD for ; Wed, 9 Jun 2021 14:57:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20F646124C for ; Wed, 9 Jun 2021 14:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238871AbhFIO73 (ORCPT ); Wed, 9 Jun 2021 10:59:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:34874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238713AbhFIO7N (ORCPT ); Wed, 9 Jun 2021 10:59:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DB43F611CC; Wed, 9 Jun 2021 14:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623250628; bh=PoYwI9DjnEQh9Wl4w4xBqnWBXjC1LGAiHsJEEJ6mXGA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cuXuDESBH4coEGxFrqh46LUUazB5vkj5TUfBOfEmOQ+WXJSt7Dx5gajXLLigJQnh8 eZj4jicxM7b5l6eQc4ZydlAStTCbKTkBwfe58PKnMKNcquIB5Uc/qv6URGWz0n6QFF sD3iB5RGzTvAU92hIOkS9u+LQeVt25AbJo5FxFZ4= Date: Wed, 9 Jun 2021 16:57:06 +0200 From: Greg KH To: Tom Rix Cc: mdf@kernel.org, michal.simek@xilinx.com, nava.manne@xilinx.com, luca@lucaceresoli.net, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files Message-ID: References: <20210608162551.3010533-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Wed, Jun 09, 2021 at 06:27:05AM -0700, Tom Rix wrote: > > On 6/9/21 2:59 AM, Greg KH wrote: > > On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote: > > > From: Tom Rix > > > > > > It is not necessary to have a xilinx- prefix on a file > > > when the file is in a xilinx/ subdir. > > > > > > Signed-off-by: Tom Rix > > > --- > > > drivers/fpga/xilinx/Makefile | 4 ++-- > > > drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 > > > drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 > > > 3 files changed, 2 insertions(+), 2 deletions(-) > > > rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) > > > rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%) > > > > > > diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile > > > index 7bb7543412790..4ac727d03e140 100644 > > > --- a/drivers/fpga/xilinx/Makefile > > > +++ b/drivers/fpga/xilinx/Makefile > > > @@ -1,7 +1,7 @@ > > > # SPDX-License-Identifier: GPL-2.0 > > > -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o > > > -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o > > > +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o > > > +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o > > You just renamed the module to be called "spi.ko"???? > > > > Did you test this thing? You can not rename modules without good > > reasons, and calling a device specific kernel module "spi.ko" is not ok. > > yes, this is a problem, I will drop the renaming patches. So you didn't test these? Again, why is this file movement necessary?