Re: [PATCH 2/8] fpga: stratix10-soc: Add missing fpga_mgr_free() call

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Jun 14, 2021 at 10:38:01AM -0700, Russ Weight wrote:
> 
> 
> On 6/14/21 10:30 AM, Greg KH wrote:
> > On Mon, Jun 14, 2021 at 10:09:03AM -0700, Moritz Fischer wrote:
> >> From: Russ Weight <russell.h.weight@intel.com>
> >>
> >> The stratix10-soc driver uses fpga_mgr_create() function and is therefore
> >> responsible to call fpga_mgr_free() to release the class driver resources.
> >> Add a missing call to fpga_mgr_free in the s10_remove() function.
> >>
> >> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> >> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> >> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> >> ---
> >>  drivers/fpga/stratix10-soc.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> >> index 657a70c5fc99..9e34bbbce26e 100644
> >> --- a/drivers/fpga/stratix10-soc.c
> >> +++ b/drivers/fpga/stratix10-soc.c
> >> @@ -454,6 +454,7 @@ static int s10_remove(struct platform_device *pdev)
> >>  	struct s10_priv *priv = mgr->priv;
> >>  
> >>  	fpga_mgr_unregister(mgr);
> >> +	fpga_mgr_free(mgr);
> >>  	stratix10_svc_free_channel(priv->chan);
> >>  
> >>  	return 0;
> >> -- 
> >> 2.31.1
> >>
> > Does this fix a specific commit?  Does it need a Fixes: and cc: stable
> > line too?
> It fixes:
> 
> e7eef1d7633a fpga: add intel stratix10 soc fpga manager driver
> 
> And yes, I think it needs the Fixes: and cc: stable lines
> 
> Moritz: Let me know if you want me to add the tags
> 
> Greg: Patch 1 in this series could be viewed as a fix for a particular
> commit as well, but the code being deleted is harmless/unused. I'm
> assuming it does NOT need the Fixes: and cc: stable lines?

All patch 1 did is delete unused code, that doesn't really "fix"
anything that could be seen as a bug :)

thanks,

greg k-h