From: Lee Jones <lee.jones@linaro.org> To: Xu Yilun <yilun.xu@intel.com> Cc: "Martin Hundebøll" <martin@geanix.com>, "Wu Hao" <hao.wu@intel.com>, "Tom Rix" <trix@redhat.com>, "Moritz Fischer" <mdf@kernel.org>, "Jean Delvare" <jdelvare@suse.com>, "Guenter Roeck" <linux@roeck-us.net>, "Mark Brown" <broonie@kernel.org>, "Martin Hundebøll" <mhu@silicom.dk>, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v2 4/5] mfd: intel-m10-bmc: add n5010 variant Date: Mon, 28 Jun 2021 11:33:39 +0100 [thread overview] Message-ID: <YNmlgz7wdJSGzMh9@dell> (raw) In-Reply-To: <20210628055942.GD72330@yilunxu-OptiPlex-7050> On Mon, 28 Jun 2021, Xu Yilun wrote: > It is good to me. Please provide a proper *-by tag: See the: 'Sign your work - the Developer's Certificate of Origin' section in Documentation/process/submitting-patches.rst And please don't top post. > On Fri, Jun 25, 2021 at 09:42:12AM +0200, Martin Hundebøll wrote: > > From: Martin Hundebøll <mhu@silicom.dk> > > > > The m10-bmc is used on the Silicom N5010 PAC too, so add it to list of > > m10bmc types. > > > > Signed-off-by: Martin Hundebøll <mhu@silicom.dk> > > --- > > > > Changes since v1: > > * Patch split out to separate mfd changes > > > > drivers/mfd/intel-m10-bmc.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c > > index 1a9bfb7f48cd..8db3bcf5fccc 100644 > > --- a/drivers/mfd/intel-m10-bmc.c > > +++ b/drivers/mfd/intel-m10-bmc.c > > @@ -15,7 +15,8 @@ > > > > enum m10bmc_type { > > M10_N3000, > > - M10_D5005 > > + M10_D5005, > > + M10_N5010, > > }; > > > > static struct mfd_cell m10bmc_d5005_subdevs[] = { > > @@ -28,6 +29,10 @@ static struct mfd_cell m10bmc_pacn3000_subdevs[] = { > > { .name = "n3000bmc-secure" }, > > }; > > > > +static struct mfd_cell m10bmc_n5010_subdevs[] = { > > + { .name = "n5010bmc-hwmon" }, > > +}; > > + > > static const struct regmap_range m10bmc_regmap_range[] = { > > regmap_reg_range(M10BMC_LEGACY_BUILD_VER, M10BMC_LEGACY_BUILD_VER), > > regmap_reg_range(M10BMC_SYS_BASE, M10BMC_SYS_END), > > @@ -192,6 +197,10 @@ static int intel_m10_bmc_spi_probe(struct spi_device *spi) > > cells = m10bmc_d5005_subdevs; > > n_cell = ARRAY_SIZE(m10bmc_d5005_subdevs); > > break; > > + case M10_N5010: > > + cells = m10bmc_n5010_subdevs; > > + n_cell = ARRAY_SIZE(m10bmc_n5010_subdevs); > > + break; > > default: > > return -ENODEV; > > } > > @@ -207,6 +216,7 @@ static int intel_m10_bmc_spi_probe(struct spi_device *spi) > > static const struct spi_device_id m10bmc_spi_id[] = { > > { "m10-n3000", M10_N3000 }, > > { "m10-d5005", M10_D5005 }, > > + { "m10-n5010", M10_N5010 }, > > { } > > }; > > MODULE_DEVICE_TABLE(spi, m10bmc_spi_id); -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-06-28 10:33 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-25 7:42 [PATCH v2 0/5] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC Martin Hundebøll 2021-06-25 7:42 ` [PATCH v2 1/5] fpga: dfl: pci: add device IDs for Silicom N501x PAC cards Martin Hundebøll 2021-06-25 18:43 ` Moritz Fischer 2021-06-25 7:42 ` [PATCH v2 2/5] fpga: dfl: expose feature revision from struct dfl_device Martin Hundebøll 2021-06-25 19:26 ` Moritz Fischer 2021-06-28 3:38 ` Wu, Hao 2021-06-25 7:42 ` [PATCH v2 3/5] spi: spi-altera-dfl: support n5010 feature revision Martin Hundebøll 2021-06-28 5:58 ` Xu Yilun 2021-06-28 17:39 ` Moritz Fischer 2021-06-29 11:35 ` Mark Brown 2021-06-29 11:49 ` Martin Hundebøll 2021-06-29 14:37 ` Wu, Hao 2021-06-29 22:30 ` matthew.gerlach 2021-06-25 7:42 ` [PATCH v2 4/5] mfd: intel-m10-bmc: add n5010 variant Martin Hundebøll 2021-06-25 18:45 ` Moritz Fischer 2021-06-29 1:39 ` Xu Yilun 2021-06-28 5:59 ` Xu Yilun 2021-06-28 10:33 ` Lee Jones [this message] 2021-06-30 10:57 ` Lee Jones 2021-06-25 7:42 ` [PATCH v2 5/5] hwmon: intel-m10-bmc-hwmon: add n5010 sensors Martin Hundebøll 2021-06-28 6:00 ` Xu Yilun 2021-06-28 14:11 ` Guenter Roeck 2021-06-28 16:35 ` Guenter Roeck 2021-06-28 17:28 ` Moritz Fischer 2021-06-29 1:40 ` Xu Yilun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNmlgz7wdJSGzMh9@dell \ --to=lee.jones@linaro.org \ --cc=broonie@kernel.org \ --cc=hao.wu@intel.com \ --cc=jdelvare@suse.com \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=martin@geanix.com \ --cc=mdf@kernel.org \ --cc=mhu@silicom.dk \ --cc=trix@redhat.com \ --cc=yilun.xu@intel.com \ --subject='Re: [PATCH v2 4/5] mfd: intel-m10-bmc: add n5010 variant' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).