From: Moritz Fischer <mdf@kernel.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: Tom Rix <trix@redhat.com>, Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] FPGA Manager address unused variable warnings
Date: Sat, 17 Jul 2021 19:00:07 -0700 [thread overview]
Message-ID: <YPOLJ6mg9WWQ9/gI@epycbox.lan> (raw)
In-Reply-To: <20210707020309.GA12358@yilunxu-OptiPlex-7050>
On Wed, Jul 07, 2021 at 10:03:09AM +0800, Xu Yilun wrote:
> On Tue, Jul 06, 2021 at 09:28:37AM -0700, Tom Rix wrote:
> >
> > On 7/1/21 8:54 PM, Moritz Fischer wrote:
> > > This patchset addresses a handful of warnings as result of_match_ids
> > > being not properly wrapped in #ifdef CONFIG_OF.
> > >
> > > Moritz Fischer (4):
> > > fpga: altera-freeze-bridge: Address warning about unused variable
> > > fpga: xiilnx-spi: Address warning about unused variable
> > > fpga: xilinx-pr-decoupler: Address warning about unused variable
> > > fpga: zynqmp-fpga: Address warning about unused variable
> > >
> > > drivers/fpga/altera-freeze-bridge.c | 2 ++
> > > drivers/fpga/xilinx-pr-decoupler.c | 2 ++
> > > drivers/fpga/xilinx-spi.c | 2 ++
> > > drivers/fpga/zynqmp-fpga.c | 3 ++-
> > > 4 files changed, 8 insertions(+), 1 deletion(-)
> >
> > I am not seeing these warnings, but it is still worth doing.
> >
> > I think a few more files need this change.
> >
> > altera-ps-spi.c, dfl-n3000-nios.c, altera-hps2fpga.c, stratix10-soc.c,
> > socfpga-a10.c, altera-fpga2sdram.c
>
> dfl-n3000-nios is not using of_device_id, and doesn't need the change.
>
> Thanks,
> Yilun
>
> >
> > Not needed for
> >
> > altera-pr-ip-core-plat.c and ice40-spi.c
> >
> > These have depends on OF in Kconfig.
> >
> > Tom
Applied to for-next,
Moritz
prev parent reply other threads:[~2021-07-18 2:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 3:54 [PATCH 0/4] FPGA Manager address unused variable warnings Moritz Fischer
2021-07-02 3:54 ` [PATCH 1/4] fpga: altera-freeze-bridge: Address warning about unused variable Moritz Fischer
2021-07-02 3:54 ` [PATCH 2/4] fpga: xiilnx-spi: " Moritz Fischer
2021-07-02 3:54 ` [PATCH 3/4] fpga: xilinx-pr-decoupler: " Moritz Fischer
2021-07-02 3:54 ` [PATCH 4/4] fpga: zynqmp-fpga: " Moritz Fischer
2021-07-06 16:28 ` [PATCH 0/4] FPGA Manager address unused variable warnings Tom Rix
2021-07-07 2:03 ` Xu Yilun
2021-07-18 2:00 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPOLJ6mg9WWQ9/gI@epycbox.lan \
--to=mdf@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).