linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fpga: versal-fpga: Remove empty functions
@ 2021-07-26  3:08 Moritz Fischer
  2021-07-27 14:40 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Moritz Fischer @ 2021-07-26  3:08 UTC (permalink / raw)
  To: linux-fpga; +Cc: trix, linux-kernel, gregkh, Moritz Fischer

Since the core framework now wraps the functions, ensuring
drives only have to implement functions that do something,
drop the now no longer required callbacks for state and
write_complete.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---

Hi Greg,

This needs to wait for the earlier pull request [1] that introduces the
wrapper functions, allowing drivers to drop the empty ones.

Unfortunately this sort of got of sync with the versal patches getting
picked up before the wrapper changes went in.


- Moritz

[1] https://lore.kernel.org/linux-fpga/YP4kHpn7CDzCYrbU@epycbox.lan/
---
 drivers/fpga/versal-fpga.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c
index 1bd312a31b23..5b0dda304bd2 100644
--- a/drivers/fpga/versal-fpga.c
+++ b/drivers/fpga/versal-fpga.c
@@ -37,22 +37,9 @@ static int versal_fpga_ops_write(struct fpga_manager *mgr,
 	return ret;
 }
 
-static int versal_fpga_ops_write_complete(struct fpga_manager *mgr,
-					  struct fpga_image_info *info)
-{
-	return 0;
-}
-
-static enum fpga_mgr_states versal_fpga_ops_state(struct fpga_manager *mgr)
-{
-	return FPGA_MGR_STATE_UNKNOWN;
-}
-
 static const struct fpga_manager_ops versal_fpga_ops = {
-	.state = versal_fpga_ops_state,
 	.write_init = versal_fpga_ops_write_init,
 	.write = versal_fpga_ops_write,
-	.write_complete = versal_fpga_ops_write_complete,
 };
 
 static int versal_fpga_probe(struct platform_device *pdev)
-- 
2.32.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fpga: versal-fpga: Remove empty functions
  2021-07-26  3:08 [PATCH] fpga: versal-fpga: Remove empty functions Moritz Fischer
@ 2021-07-27 14:40 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-07-27 14:40 UTC (permalink / raw)
  To: Moritz Fischer; +Cc: linux-fpga, trix, linux-kernel

On Sun, Jul 25, 2021 at 08:08:06PM -0700, Moritz Fischer wrote:
> Since the core framework now wraps the functions, ensuring
> drives only have to implement functions that do something,
> drop the now no longer required callbacks for state and
> write_complete.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> 
> Hi Greg,
> 
> This needs to wait for the earlier pull request [1] that introduces the
> wrapper functions, allowing drivers to drop the empty ones.
> 
> Unfortunately this sort of got of sync with the versal patches getting
> picked up before the wrapper changes went in.

As I said to your pull request, you can now add it to the new request
you will be sending me :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-27 14:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26  3:08 [PATCH] fpga: versal-fpga: Remove empty functions Moritz Fischer
2021-07-27 14:40 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).