From: Moritz Fischer <mdf@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Russ Weight <russell.h.weight@intel.com>,
mdf@kernel.org, linux-fpga@vger.kernel.org, trix@redhat.com,
lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com,
matthew.gerlach@intel.com, rc@silicom.dk, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] fpga: dfl: Avoid reads to AFU CSRs during enumeration
Date: Fri, 17 Sep 2021 09:26:07 -0700 [thread overview]
Message-ID: <YUTBn+klY2i0QNgn@epycbox.lan> (raw)
In-Reply-To: <YUQqxBaRHH/Hnk6z@kroah.com>
On Fri, Sep 17, 2021 at 07:42:28AM +0200, Greg KH wrote:
> On Thu, Sep 16, 2021 at 02:07:33PM -0700, Russ Weight wrote:
> > CSR address space for Accelerator Functional Units (AFU) is not available
> > during the early Device Feature List (DFL) enumeration. Early access
> > to this space results in invalid data and port errors. This change adds
> > a condition to prevent an early read from the AFU CSR space.
> >
> > Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> >
> > Fixes: 23bcda750558 ("fpga: dfl: expose feature revision from struct
> > dfl_device")
>
> Nit, please keep this all on one line or our tools will complain about
> it when we commit it to our trees :(
I had caught that and fixed it when applying :)
Thanks,
Moritz
prev parent reply other threads:[~2021-09-17 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 21:07 [PATCH 1/1] fpga: dfl: Avoid reads to AFU CSRs during enumeration Russ Weight
2021-09-16 22:24 ` Moritz Fischer
2021-09-16 22:34 ` Russ Weight
2021-09-16 22:50 ` Moritz Fischer
2021-09-17 18:24 ` Russ Weight
2021-09-17 5:42 ` Greg KH
2021-09-17 16:26 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUTBn+klY2i0QNgn@epycbox.lan \
--to=mdf@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=rc@silicom.dk \
--cc=russell.h.weight@intel.com \
--cc=stable@vger.kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).